Add support for generating namespaced constant

Author: ranvis

build/gen_stub.php

@@ -931,8 +931,11 @@ public function isUnknown(): bool
 class ConstName extends AbstractConstName {
     public string $const;
 
-    public function __construct(string $const)
+    public function __construct(?Name $namespace, string $const)
     {
+        if ($namespace && ($namespace = $namespace->slice(0, -1))) {
+            $const = $namespace->toString() . '\\' . $const;
+        }
         $this->const = $const;
     }
 
@@ -1600,7 +1603,7 @@ public function enterNode(Node $expr)
                 if ($expr instanceof Expr\ClassConstFetch) {
                     $originatingConstName = new ClassConstName($expr->class, $expr->name->toString());
                 } else {
-                    $originatingConstName = new ConstName($expr->name->toString());
+                    $originatingConstName = new ConstName($expr->name->getAttribute('namespacedName'), $expr->name->toString());
                 }
 
                 if ($originatingConstName->isUnknown()) {
@@ -1658,7 +1661,7 @@ function (Expr $expr) use ($allConstInfos, &$isUnknownConstValue) {
                     return null;
                 }
 
-                throw new Exception("Constant " . $originatingConstName->__toString() . " cannot be found");
+                throw new Exception("Constant " . $constName . " cannot be found");
             }
         );
 
@@ -3677,7 +3680,7 @@ function handleStatements(FileInfo $fileInfo, array $stmts, PrettyPrinterAbstrac
             foreach ($stmt->consts as $const) {
                 $fileInfo->constInfos[] = parseConstLike(
                     $prettyPrinter,
-                    new ConstName($const->name->toString()),
+                    new ConstName($const->namespacedName, $const->name->toString()),
                     $const,
                     0,
                     $stmt->getDocComment(),

ext/ftp/ftp.stub.php

@@ -2,7 +2,7 @@
 
 /** @generate-class-entries */
 
-namespace FTP {
+namespace {
     /**
      * @var int
      * @cvalue FTPTYPE_ASCII
@@ -59,16 +59,6 @@
      */
     const FTP_MOREDATA = UNKNOWN;
 
-    /**
-     * @strict-properties
-     * @not-serializable
-     */
-    final class Connection
-    {
-    }
-}
-
-namespace {
     function ftp_connect(string $hostname, int $port = 21, int $timeout = 90): FTP\Connection|false {}
 
     #ifdef HAVE_FTP_SSL
@@ -145,3 +135,13 @@ function ftp_quit(FTP\Connection $ftp): bool {}
     function ftp_set_option(FTP\Connection $ftp, int $option, $value): bool {}
     function ftp_get_option(FTP\Connection $ftp, int $option): int|bool {}
 }
+
+namespace FTP {
+    /**
+     * @strict-properties
+     * @not-serializable
+     */
+    final class Connection
+    {
+    }
+}

ext/ftp/ftp_arginfo.h

@@ -2,7 +2,7 @@
 
 /** @generate-class-entries */
 
-namespace PgSql {
+namespace {
     /* libpq version */
 
     /**
@@ -413,34 +413,6 @@
      */
     const PGSQL_DML_STRING = UNKNOWN;
 
-    /**
-     * @strict-properties
-     * @not-serializable
-     */
-    final class Connection
-    {
-    }
-
-    /**
-     * @strict-properties
-     * @not-serializable
-     */
-    final class Result
-    {
-    }
-
-    /**
-     * @strict-properties
-     * @not-serializable
-     */
-    final class Lob
-    {
-    }
-
-}
-
-namespace {
-
     function pg_connect(string $connection_string, int $flags = 0): PgSql\Connection|false {}
 
     function pg_pconnect(string $connection_string, int $flags = 0): PgSql\Connection|false {}
@@ -923,3 +895,30 @@ function pg_delete(PgSql\Connection $connection, string $table_name, array $cond
      */
     function pg_select(PgSql\Connection $connection, string $table_name, array $conditions, int $flags = PGSQL_DML_EXEC, int $mode = PGSQL_ASSOC): array|string|false {}
 }
+
+namespace PgSql {
+    /**
+     * @strict-properties
+     * @not-serializable
+     */
+    final class Connection
+    {
+    }
+
+    /**
+     * @strict-properties
+     * @not-serializable
+     */
+    final class Result
+    {
+    }
+
+    /**
+     * @strict-properties
+     * @not-serializable
+     */
+    final class Lob
+    {
+    }
+
+}

ext/pgsql/pgsql.stub.php

@@ -12,6 +12,9 @@
      */
     const ZEND_TEST_DEPRECATED = 42;
 
+    /** @var string */
+    const ZEND_CONSTANT_A = "global";
+
     require "Zend/zend_attributes.stub.php";
 
     interface _ZendTestInterface
@@ -199,6 +202,9 @@ public function method(): ?UnlikelyCompileError {}
 
 namespace ZendTestNS2 {
 
+    /** @var string */
+    const ZEND_CONSTANT_A = "namespaced";
+
     class Foo {
         public ZendSubNS\Foo $foo;
 
@@ -222,6 +228,10 @@ function namespaced_deprecated_aliased_func(): void {}
 
 namespace ZendTestNS2\ZendSubNS {
 
+    /** @var string */
+    const ZEND_CONSTANT_A = \ZendTestNS2\ZEND_CONSTANT_A;
+    // Reference another namespaced constant.
+
     class Foo {
         public function method(): void {}
     }

ext/pgsql/pgsql_arginfo.h

@@ -0,0 +1,16 @@
+--TEST--
+gen_stub.php: constants
+--EXTENSIONS--
+zend_test
+--FILE--
+<?php
+
+var_dump(ZEND_CONSTANT_A);
+var_dump(ZendTestNS2\ZEND_CONSTANT_A);
+var_dump(ZendTestNS2\ZendSubNS\ZEND_CONSTANT_A);
+
+?>
+--EXPECT--
+string(6) "global"
+string(10) "namespaced"
+string(10) "namespaced"