Throw notice for plain wrapper fread/fwrite errors

Similar to what is done for socket read/write errors.

Author: nikic

UPGRADING

@@ -142,6 +142,8 @@ PHP 7.4 UPGRADE NOTES
   . fread() and fwrite() will now return false if the operation failed.
     Previously an empty string or 0 was returned. EAGAIN/EWOULDBLOCK are not
     considered failures.
+  . fread() and fwrite() on plain files will now throw a notice on failure,
+    such as when trying to write to a read-only file resource.
 
 - Tokenizer:
   . token_get_all() will now emit a T_BAD_CHARACTER token for unexpected

ext/fileinfo/tests/bug61964-mb.phpt

@@ -45,11 +45,10 @@ rmdir($dir);
 ?>
 ===DONE===
 --EXPECTF--
-bool(false)
+bool(false)%A
 resource(%d) of type (file_info)
 resource(%d) of type (file_info)
-bool(false)
-
+bool(false)%A
 Notice: finfo_open(): Warning: offset `string' invalid in %sbug61964-mb.php on line %d
 
 Notice: finfo_open(): Warning: offset ` Core' invalid in %sbug61964-mb.php on line %d

ext/fileinfo/tests/bug61964.phpt

@@ -45,11 +45,10 @@ rmdir($dir);
 ?>
 ===DONE===
 --EXPECTF--
-bool(false)
+bool(false)%A
 resource(%d) of type (file_info)
 resource(%d) of type (file_info)
-bool(false)
-
+bool(false)%A
 Notice: finfo_open(): Warning: offset `string' invalid in %sbug61964.php on line %d
 
 Notice: finfo_open(): Warning: offset ` Core' invalid in %sbug61964.php on line %d

ext/standard/tests/file/007_variation1.phpt

@@ -48,6 +48,8 @@ int(0)
 string(20) "line
 line of text
 li"
+
+Notice: fwrite(): write of 37 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 bool(true)
 string(7) "Unknown"

ext/standard/tests/file/007_variation11-win32-mb.phpt

@@ -68,6 +68,8 @@ string(6) "stream"
 int(0)
 int(37)
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation11-win32.phpt

@@ -66,6 +66,8 @@ string(6) "stream"
 int(0)
 int(37)
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation11.phpt

@@ -66,6 +66,8 @@ string(6) "stream"
 int(0)
 int(37)
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation13-win32.phpt

@@ -56,6 +56,8 @@ unlink(__DIR__."/007_variation13.tmp");
 resource(%d) of type (stream)
 string(6) "stream"
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation13.phpt

@@ -56,6 +56,8 @@ unlink(__DIR__."/007_variation13.tmp");
 resource(%d) of type (stream)
 string(6) "stream"
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation15.phpt

@@ -49,6 +49,8 @@ string(6) "stream"
 int(0)
 int(37)
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation17.phpt

@@ -48,6 +48,8 @@ int(0)
 string(20) "line
 line of text
 li"
+
+Notice: fwrite(): write of 37 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 bool(true)
 string(7) "Unknown"

ext/standard/tests/file/007_variation19.phpt

@@ -61,6 +61,8 @@ string(6) "stream"
 int(0)
 int(37)
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation21.phpt

@@ -51,6 +51,8 @@ unlink(__DIR__."/007_variation21.tmp");
 resource(%d) of type (stream)
 string(6) "stream"
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation23.phpt

@@ -49,6 +49,8 @@ string(6) "stream"
 int(0)
 int(37)
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation3.phpt

@@ -61,6 +61,8 @@ string(6) "stream"
 int(0)
 int(37)
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation5.phpt

@@ -51,6 +51,8 @@ unlink(__DIR__."/007_variation5.tmp");
 resource(%d) of type (stream)
 string(6) "stream"
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation7.phpt

@@ -49,6 +49,8 @@ string(6) "stream"
 int(0)
 int(37)
 int(37)
+
+Notice: fread(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(true)

ext/standard/tests/file/007_variation9.phpt

@@ -48,6 +48,8 @@ int(0)
 string(20) "line
 line of text
 li"
+
+Notice: fwrite(): write of 37 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 bool(true)
 string(7) "Unknown"

ext/standard/tests/file/bug35781.phpt

@@ -18,7 +18,8 @@ var_dump(file_get_contents($filename));
 
 echo "Done\n";
 ?>
---EXPECT--
+--EXPECTF--
+Notice: fpassthru(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 string(15) "Guvf vf n grfg
 "
 Done

ext/standard/tests/file/fgetc_variation3.phpt

@@ -49,68 +49,86 @@ foreach ($file_modes as $file_mode ) {
 
 echo "Done\n";
 ?>
---EXPECT--
+--EXPECTF--
 *** Testing fgetc() with file opened in write only mode ***
 -- File opened in mode : w --
 bool(true)
 int(0)
 bool(false)
+
+Notice: fgetc(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(false)
 -- File opened in mode : wb --
 bool(true)
 int(0)
 bool(false)
+
+Notice: fgetc(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(false)
 -- File opened in mode : wt --
 bool(true)
 int(0)
 bool(false)
+
+Notice: fgetc(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(false)
 -- File opened in mode : a --
 bool(true)
 int(0)
 bool(false)
+
+Notice: fgetc(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(false)
 -- File opened in mode : ab --
 bool(true)
 int(0)
 bool(false)
+
+Notice: fgetc(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(false)
 -- File opened in mode : at --
 bool(true)
 int(0)
 bool(false)
+
+Notice: fgetc(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(false)
 -- File opened in mode : x --
 bool(true)
 int(0)
 bool(false)
+
+Notice: fgetc(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(false)
 -- File opened in mode : xb --
 bool(true)
 int(0)
 bool(false)
+
+Notice: fgetc(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(false)
 -- File opened in mode : xt --
 bool(true)
 int(0)
 bool(false)
+
+Notice: fgetc(): read of 8192 bytes failed with errno=9 Bad file descriptor in %s on line %d
 bool(false)
 int(0)
 bool(false)