Skip to content

Commit 1c8f106

Browse files
committed
Merge branch 'PHP-5.4' into PHP-5.5
* PHP-5.4: fix bug #63666 - Poor date() performance
2 parents 86bf83d + fd650ec commit 1c8f106

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

ext/date/php_date.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -952,6 +952,7 @@ static char *date_format(char *format, int format_len, timelib_time *t, int loca
952952
timelib_time_offset *offset = NULL;
953953
timelib_sll isoweek, isoyear;
954954
int rfc_colon;
955+
int weekYearSet = 0;
955956

956957
if (!format_len) {
957958
return estrdup("");
@@ -978,7 +979,6 @@ static char *date_format(char *format, int format_len, timelib_time *t, int loca
978979
offset = timelib_get_time_zone_info(t->sse, t->tz_info);
979980
}
980981
}
981-
timelib_isoweek_from_date(t->y, t->m, t->d, &isoweek, &isoyear);
982982

983983
for (i = 0; i < format_len; i++) {
984984
rfc_colon = 0;
@@ -994,8 +994,12 @@ static char *date_format(char *format, int format_len, timelib_time *t, int loca
994994
case 'z': length = slprintf(buffer, 32, "%d", (int) timelib_day_of_year(t->y, t->m, t->d)); break;
995995

996996
/* week */
997-
case 'W': length = slprintf(buffer, 32, "%02d", (int) isoweek); break; /* iso weeknr */
998-
case 'o': length = slprintf(buffer, 32, "%d", (int) isoyear); break; /* iso year */
997+
case 'W':
998+
if(!weekYearSet) { timelib_isoweek_from_date(t->y, t->m, t->d, &isoweek, &isoyear); weekYearSet = 1; }
999+
length = slprintf(buffer, 32, "%02d", (int) isoweek); break; /* iso weeknr */
1000+
case 'o':
1001+
if(!weekYearSet) { timelib_isoweek_from_date(t->y, t->m, t->d, &isoweek, &isoyear); weekYearSet = 1; }
1002+
length = slprintf(buffer, 32, "%d", (int) isoyear); break; /* iso year */
9991003

10001004
/* month */
10011005
case 'F': length = slprintf(buffer, 32, "%s", mon_full_names[t->m - 1]); break;

0 commit comments

Comments
 (0)