Skip to content

Commit 195c200

Browse files
committed
Fix #78642: Wrong libiconv version displayed
The high byte of `_libiconv_version` specifies the major version; the low byte the minor version.
1 parent 05d6878 commit 195c200

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

NEWS

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@ PHP NEWS
22
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
33
?? ??? 2019, PHP 7.2.25
44

5+
- Iconv:
6+
. Fixed bug #78642 (Wrong libiconv version displayed). (gedas at martynas,
7+
cmb).
58

69
24 Oct 2019, PHP 7.2.24
710

ext/iconv/iconv.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,7 +286,7 @@ PHP_MINIT_FUNCTION(miconv)
286286
{
287287
static char buf[16];
288288
snprintf(buf, sizeof(buf), "%d.%d",
289-
((_libiconv_version >> 8) & 0x0f), (_libiconv_version & 0x0f));
289+
_libiconv_version >> 8, _libiconv_version & 0xff);
290290
version = buf;
291291
}
292292
#elif HAVE_GLIBC_ICONV

0 commit comments

Comments
 (0)