adds test case for #11883

Note that this test only fails if valgrind is run with
the `--leak-check=full` flag.

Author: ju1ius

Zend/tests/type_declarations/dnf_types/internal_dnf_property.phpt

@@ -0,0 +1,25 @@
+--TEST--
+DNF typed properties in internal classes
+--EXTENSIONS--
+zend_test
+spl
+reflection
+--FILE--
+<?php
+
+$prop = new \ReflectionProperty(_ZendTestClass::class, 'dnfProperty');
+$type = $prop->getType();
+var_dump((string)$type);
+
+$obj = new _ZendTestClass();
+$obj->dnfProperty = new \ArrayIterator([1, 2, 3]);
+try {
+    $obj->dnfProperty = [];
+} catch (TypeError $e) {
+    echo $e->getMessage(), "\n";
+}
+?>
+--EXPECT--
+string(32) "Iterator|(Traversable&Countable)"
+Cannot assign array to property _ZendTestClass::$dnfProperty of type Iterator|(Traversable&Countable)
+

Zend/tests/type_declarations/typed_properties_095.phpt

@@ -75,6 +75,8 @@ object(_ZendTestClass)#1 (3) {
   uninitialized(Traversable&Countable)
   ["readonlyProp"]=>
   uninitialized(int)
+  ["dnfProperty"]=>
+  uninitialized(Iterator|(Traversable&Countable))
 }
 int(123)
 Cannot assign string to property _ZendTestClass::$intProp of type int
@@ -91,6 +93,8 @@ object(Test)#4 (3) {
   uninitialized(Traversable&Countable)
   ["readonlyProp"]=>
   uninitialized(int)
+  ["dnfProperty"]=>
+  uninitialized(Iterator|(Traversable&Countable))
 }
 int(123)
 Cannot assign string to property _ZendTestClass::$staticIntProp of type int

ext/zend_test/test.c

@@ -884,11 +884,42 @@ static void le_throwing_resource_dtor(zend_resource *rsrc)
 	zend_throw_exception(NULL, "Throwing resource destructor called", 0);
 }
 
+// We need to "manually" generate this property because gen_stubs.php
+// does not support codegen for DNF types.
+static void register_ZendTestClass_dnf_property(zend_class_entry *ce) {
+	zend_string *class_Iterator = zend_string_init_interned("Iterator", sizeof("Iterator") - 1, true);
+	zend_alloc_ce_cache(class_Iterator);
+	zend_string *class_Traversable = zend_string_init_interned("Traversable", sizeof("Traversable") - 1, true);
+	zend_alloc_ce_cache(class_Traversable);
+	zend_string *class_Countable = zend_string_init_interned("Countable", sizeof("Countable") - 1, true);
+	zend_alloc_ce_cache(class_Countable);
+	//
+	zend_type_list *intersection_type_list = malloc(ZEND_TYPE_LIST_SIZE(2));
+	intersection_type_list->num_types = 2;
+	intersection_type_list->types[0] = (zend_type) ZEND_TYPE_INIT_CLASS(class_Traversable, 0, 0);
+	intersection_type_list->types[1] = (zend_type) ZEND_TYPE_INIT_CLASS(class_Countable, 0, 0);
+	zend_type_list *union_type_list = malloc(ZEND_TYPE_LIST_SIZE(2));
+	union_type_list->num_types = 2;
+	union_type_list->types[0] = (zend_type) ZEND_TYPE_INIT_CLASS(class_Iterator, 0, 0);
+	union_type_list->types[1] = (zend_type) ZEND_TYPE_INIT_INTERSECTION(intersection_type_list, 0);
+	zend_type prop_type = (zend_type) ZEND_TYPE_INIT_UNION(union_type_list, 0);
+	//
+	zend_string *prop_name = zend_string_init_interned("dnfProperty", sizeof("dnfProperty") - 1, true);
+	zval default_value;
+	ZVAL_UNDEF(&default_value);
+	// We need this hack because some debug assertions incorrectly reject valid DNF types.
+	// see https://github.com/php/php-src/issues/10120#issuecomment-1360682804
+	zend_type hack = {0};
+	zend_property_info *prop = zend_declare_typed_property(ce, prop_name, &default_value, ZEND_ACC_PUBLIC, NULL, hack);
+	prop->type = prop_type;
+}
+
 PHP_MINIT_FUNCTION(zend_test)
 {
 	zend_test_interface = register_class__ZendTestInterface();
 
 	zend_test_class = register_class__ZendTestClass(zend_test_interface);
+	register_ZendTestClass_dnf_property(zend_test_class);
 	zend_test_class->create_object = zend_test_class_new;
 	zend_test_class->get_static_method = zend_test_class_static_method_get;