Implement __serialize() and __unserialize() on GMP

GMP directly implements internal serialize/unserialize handlers
rather than going through the Serializable interface, so it ended
up being missed when adding the new __serialize()/__unserialize()
methods to other classes.

The serialization format is similar to before, but uses hex instead
of decimal encoding and omits the members if not used (which should
be almost always).

Author: nikic

ext/gmp/gmp.c

@@ -2017,3 +2017,48 @@ ZEND_FUNCTION(gmp_scan1)
 	FREE_GMP_TEMP(temp_a);
 }
 /* }}} */
+
+ZEND_METHOD(GMP, __serialize)
+{
+	ZEND_PARSE_PARAMETERS_NONE();
+
+	zval zv;
+	array_init(return_value);
+
+	mpz_ptr gmpnum = GET_GMP_FROM_ZVAL(ZEND_THIS);
+	gmp_strval(&zv, gmpnum, 16);
+	zend_hash_next_index_insert(Z_ARRVAL_P(return_value), &zv);
+
+	HashTable *props = Z_OBJ_P(ZEND_THIS)->properties;
+	if (props && zend_hash_num_elements(props) != 0) {
+		ZVAL_ARR(&zv, zend_proptable_to_symtable(
+			zend_std_get_properties(Z_OBJ_P(ZEND_THIS)), /* always duplicate */ 1));
+		zend_hash_next_index_insert(Z_ARRVAL_P(return_value), &zv);
+	}
+}
+
+ZEND_METHOD(GMP, __unserialize)
+{
+	HashTable *data;
+
+	ZEND_PARSE_PARAMETERS_START(1, 1)
+		Z_PARAM_ARRAY_HT(data)
+	ZEND_PARSE_PARAMETERS_END();
+
+	zval *num = zend_hash_index_find(data, 0);
+	if (!num || Z_TYPE_P(num) != IS_STRING ||
+			convert_to_gmp(GET_GMP_FROM_ZVAL(ZEND_THIS), num, 16, 0) == FAILURE) {
+		zend_throw_exception(NULL, "Could not unserialize number", 0);
+		RETURN_THROWS();
+	}
+
+	zval *props = zend_hash_index_find(data, 1);
+	if (props) {
+		if (Z_TYPE_P(props) != IS_ARRAY) {
+			zend_throw_exception(NULL, "Could not unserialize properties", 0);
+			RETURN_THROWS();
+		}
+
+		object_properties_load(Z_OBJ_P(ZEND_THIS), Z_ARRVAL_P(props));
+	}
+}

ext/gmp/gmp.stub.php

@@ -4,6 +4,9 @@
 
 class GMP
 {
+    public function __serialize(): array {}
+
+    public function __unserialize(array $data): void {}
 }
 
 function gmp_init(int|string $num, int $base = 0): GMP {}

ext/gmp/gmp_arginfo.h

@@ -1,5 +1,5 @@
 /* This is a generated file, edit the .stub.php file instead.
- * Stub hash: 05e618ec428bd8769410153469c42cbc923ea77f */
+ * Stub hash: be077a57bc9ddbb9100fadfb212857c0b8f21ebf */
 
 ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_gmp_init, 0, 1, GMP, 0)
 	ZEND_ARG_TYPE_MASK(0, num, MAY_BE_LONG|MAY_BE_STRING, NULL)
@@ -184,6 +184,13 @@ ZEND_BEGIN_ARG_WITH_RETURN_OBJ_INFO_EX(arginfo_gmp_binomial, 0, 2, GMP, 0)
 	ZEND_ARG_TYPE_INFO(0, k, IS_LONG, 0)
 ZEND_END_ARG_INFO()
 
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_GMP___serialize, 0, 0, IS_ARRAY, 0)
+ZEND_END_ARG_INFO()
+
+ZEND_BEGIN_ARG_WITH_RETURN_TYPE_INFO_EX(arginfo_class_GMP___unserialize, 0, 1, IS_VOID, 0)
+	ZEND_ARG_TYPE_INFO(0, data, IS_ARRAY, 0)
+ZEND_END_ARG_INFO()
+
 
 ZEND_FUNCTION(gmp_init);
 ZEND_FUNCTION(gmp_import);
@@ -235,6 +242,8 @@ ZEND_FUNCTION(gmp_popcount);
 ZEND_FUNCTION(gmp_hamdist);
 ZEND_FUNCTION(gmp_nextprime);
 ZEND_FUNCTION(gmp_binomial);
+ZEND_METHOD(GMP, __serialize);
+ZEND_METHOD(GMP, __unserialize);
 
 
 static const zend_function_entry ext_functions[] = {
@@ -294,6 +303,8 @@ static const zend_function_entry ext_functions[] = {
 
 
 static const zend_function_entry class_GMP_methods[] = {
+	ZEND_ME(GMP, __serialize, arginfo_class_GMP___serialize, ZEND_ACC_PUBLIC)
+	ZEND_ME(GMP, __unserialize, arginfo_class_GMP___unserialize, ZEND_ACC_PUBLIC)
 	ZEND_FE_END
 };
 

ext/gmp/tests/serialize.phpt

@@ -11,7 +11,10 @@ var_dump(unserialize($s));
 
 $n = gmp_init(13);
 $n->foo = "bar";
-var_dump(unserialize(serialize($n)));
+var_dump($s = serialize($n));
+var_dump(unserialize($s));
+
+var_dump(unserialize('C:3:"GMP":15:{s:2:"42";a:0:{}}'));
 
 try {
     unserialize('C:3:"GMP":0:{}');
@@ -21,22 +24,47 @@ try {
     unserialize('C:3:"GMP":9:{s:2:"42";}');
 } catch (Exception $e) { var_dump($e->getMessage()); }
 
+try {
+    unserialize('O:3:"GMP":0:{}');
+} catch (Exception $e) { var_dump($e->getMessage()); }
+
+try {
+    unserialize('O:3:"GMP":1:{i:0;i:0;}');
+} catch (Exception $e) { var_dump($e->getMessage()); }
+
+try {
+    unserialize('O:3:"GMP":1:{i:0;s:0:"";}');
+} catch (Exception $e) { var_dump($e->getMessage()); }
+
+try {
+    unserialize('O:3:"GMP":2:{i:0;s:1:"0";i:1;i:0;}');
+} catch (Exception $e) { var_dump($e->getMessage()); }
+
 ?>
 --EXPECTF--
 object(GMP)#%d (1) {
   ["num"]=>
   string(2) "42"
 }
-string(30) "C:3:"GMP":15:{s:2:"42";a:0:{}}"
+string(27) "O:3:"GMP":1:{i:0;s:2:"2a";}"
 object(GMP)#%d (1) {
   ["num"]=>
   string(2) "42"
 }
+string(56) "O:3:"GMP":2:{i:0;s:1:"d";i:1;a:1:{s:3:"foo";s:3:"bar";}}"
 object(GMP)#%d (2) {
   ["foo"]=>
   string(3) "bar"
   ["num"]=>
   string(2) "13"
 }
+object(GMP)#1 (1) {
+  ["num"]=>
+  string(2) "42"
+}
+string(28) "Could not unserialize number"
+string(32) "Could not unserialize properties"
+string(28) "Could not unserialize number"
+string(28) "Could not unserialize number"
 string(28) "Could not unserialize number"
 string(32) "Could not unserialize properties"