ext/mbstring: mb_ereg*_replace remove unreachable code. (#18646)

devnexen · web-flow · commit 16e154a2c4d0 · 2025-05-25T10:44:59.000+01:00
diff --git a/ext/mbstring/php_mbregex.c b/ext/mbstring/php_mbregex.c
@@ -1106,12 +1106,6 @@ static void _php_mb_regex_ereg_replace_exec(INTERNAL_FUNCTION_PARAMETERS, OnigOp
 					smart_str_appendl(&out_buf, Z_STRVAL(retval), Z_STRLEN(retval));
 					smart_str_free(&eval_buf);
 					zval_ptr_dtor(&retval);
-				} else {
-					if (!EG(exception)) {
-						zend_throw_error(NULL, "Unable to call custom replacement function");
-						zval_ptr_dtor(&subpats);
-						RETURN_THROWS();
-					}
 				}
 				zval_ptr_dtor(&subpats);
 			}

Original file line number	Diff line number	Diff line change
`@@ -1106,12 +1106,6 @@ static void _php_mb_regex_ereg_replace_exec(INTERNAL_FUNCTION_PARAMETERS, OnigOp`
`1106`	`1106`	`smart_str_appendl(&out_buf, Z_STRVAL(retval), Z_STRLEN(retval));`
`1107`	`1107`	`smart_str_free(&eval_buf);`
`1108`	`1108`	`zval_ptr_dtor(&retval);`
`1109`		`- } else {`
`1110`		`- if (!EG(exception)) {`
`1111`		`- zend_throw_error(NULL, "Unable to call custom replacement function");`
`1112`		`- zval_ptr_dtor(&subpats);`
`1113`		`- RETURN_THROWS();`
`1114`		`- }`
`1115`	`1109`	`}`
`1116`	`1110`	`zval_ptr_dtor(&subpats);`
`1117`	`1111`	`}`