Skip to content

Commit 166175b

Browse files
committed
Rename variables
1 parent b6cec55 commit 166175b

File tree

1 file changed

+11
-11
lines changed

1 file changed

+11
-11
lines changed

Zend/zend_inheritance.c

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1563,7 +1563,7 @@ ZEND_API void zend_do_inheritance_ex(zend_class_entry *ce, zend_class_entry *par
15631563

15641564
static zend_always_inline bool check_trait_property_or_constant_value_compatibility(zend_class_entry *ce, zval *op1, zval *op2) /* {{{ */
15651565
{
1566-
bool compatible;
1566+
bool is_compatible;
15671567
zval op1_tmp, op2_tmp;
15681568

15691569
/* if any of the values is a constant, we try to resolve it */
@@ -1578,7 +1578,7 @@ static zend_always_inline bool check_trait_property_or_constant_value_compatibil
15781578
op2 = &op2_tmp;
15791579
}
15801580

1581-
compatible = !fast_is_not_identical_function(op1, op2);
1581+
is_compatible = !fast_is_not_identical_function(op1, op2);
15821582

15831583
if (op1 == &op1_tmp) {
15841584
zval_ptr_dtor_nogc(&op1_tmp);
@@ -1587,7 +1587,7 @@ static zend_always_inline bool check_trait_property_or_constant_value_compatibil
15871587
zval_ptr_dtor_nogc(&op2_tmp);
15881588
}
15891589

1590-
return compatible;
1590+
return is_compatible;
15911591
}
15921592
/* }}} */
15931593

@@ -2174,7 +2174,7 @@ static zend_class_entry* find_first_constant_definition(zend_class_entry *ce, ze
21742174
static bool do_trait_constant_check(
21752175
zend_class_entry *ce, zend_class_constant *trait_constant, zend_string *name, zend_class_entry **traits, size_t current_trait
21762176
) {
2177-
bool compatible = false;
2177+
bool is_compatible = false;
21782178
uint32_t flags_mask = ZEND_ACC_PPP_MASK | ZEND_ACC_FINAL;
21792179

21802180
zval *zv = zend_hash_find_known_hash(&ce->constants_table, name);
@@ -2188,17 +2188,17 @@ static bool do_trait_constant_check(
21882188
return true;
21892189
}
21902190
if ((ZEND_CLASS_CONST_FLAGS(trait_constant) & flags_mask) == (ZEND_CLASS_CONST_FLAGS(old_constant) & flags_mask)) {
2191-
compatible = check_trait_property_or_constant_value_compatibility(ce, &trait_constant->value, &old_constant->value);
2191+
is_compatible = check_trait_property_or_constant_value_compatibility(ce, &trait_constant->value, &old_constant->value);
21922192
}
2193-
if (!compatible) {
2193+
if (!is_compatible) {
21942194
zend_error_noreturn(E_COMPILE_ERROR,
21952195
"%s and %s define the same constant (%s) in the composition of %s. However, the definition differs and is considered incompatible. Class was composed",
21962196
ZSTR_VAL(find_first_constant_definition(ce, traits, current_trait, name, old_constant->ce)->name),
21972197
ZSTR_VAL(trait_constant->ce->name),
21982198
ZSTR_VAL(name),
21992199
ZSTR_VAL(ce->name));
22002200
}
2201-
return compatible;
2201+
return is_compatible;
22022202
}
22032203
/* }}} */
22042204

@@ -2267,13 +2267,13 @@ static void zend_do_traits_property_and_constant_binding(zend_class_entry *ce, z
22672267
zend_hash_del(&ce->properties_info, prop_name);
22682268
flags |= ZEND_ACC_CHANGED;
22692269
} else {
2270-
bool compatible = false;
2270+
bool is_compatible = false;
22712271
uint32_t flags_mask = ZEND_ACC_PPP_MASK | ZEND_ACC_STATIC | ZEND_ACC_READONLY;
22722272

22732273
if ((colliding_prop->flags & flags_mask) == (flags & flags_mask) &&
22742274
property_types_compatible(property_info, colliding_prop) == INHERITANCE_SUCCESS
22752275
) {
2276-
/* the flags are identical, thus, the properties may be compatible */
2276+
/* the flags are identical, thus, the properties may be is_compatible */
22772277
zval *op1, *op2;
22782278

22792279
if (flags & ZEND_ACC_STATIC) {
@@ -2285,10 +2285,10 @@ static void zend_do_traits_property_and_constant_binding(zend_class_entry *ce, z
22852285
op1 = &ce->default_properties_table[OBJ_PROP_TO_NUM(colliding_prop->offset)];
22862286
op2 = &traits[i]->default_properties_table[OBJ_PROP_TO_NUM(property_info->offset)];
22872287
}
2288-
compatible = check_trait_property_or_constant_value_compatibility(ce, op1, op2);
2288+
is_compatible = check_trait_property_or_constant_value_compatibility(ce, op1, op2);
22892289
}
22902290

2291-
if (!compatible) {
2291+
if (!is_compatible) {
22922292
zend_error_noreturn(E_COMPILE_ERROR,
22932293
"%s and %s define the same property ($%s) in the composition of %s. However, the definition differs and is considered incompatible. Class was composed",
22942294
ZSTR_VAL(find_first_property_definition(ce, traits, i, prop_name, colliding_prop->ce)->name),

0 commit comments

Comments
 (0)