@@ -1563,7 +1563,7 @@ ZEND_API void zend_do_inheritance_ex(zend_class_entry *ce, zend_class_entry *par
1563
1563
1564
1564
static zend_always_inline bool check_trait_property_or_constant_value_compatibility (zend_class_entry * ce , zval * op1 , zval * op2 ) /* {{{ */
1565
1565
{
1566
- bool compatible ;
1566
+ bool is_compatible ;
1567
1567
zval op1_tmp , op2_tmp ;
1568
1568
1569
1569
/* if any of the values is a constant, we try to resolve it */
@@ -1578,7 +1578,7 @@ static zend_always_inline bool check_trait_property_or_constant_value_compatibil
1578
1578
op2 = & op2_tmp ;
1579
1579
}
1580
1580
1581
- compatible = !fast_is_not_identical_function (op1 , op2 );
1581
+ is_compatible = !fast_is_not_identical_function (op1 , op2 );
1582
1582
1583
1583
if (op1 == & op1_tmp ) {
1584
1584
zval_ptr_dtor_nogc (& op1_tmp );
@@ -1587,7 +1587,7 @@ static zend_always_inline bool check_trait_property_or_constant_value_compatibil
1587
1587
zval_ptr_dtor_nogc (& op2_tmp );
1588
1588
}
1589
1589
1590
- return compatible ;
1590
+ return is_compatible ;
1591
1591
}
1592
1592
/* }}} */
1593
1593
@@ -2174,7 +2174,7 @@ static zend_class_entry* find_first_constant_definition(zend_class_entry *ce, ze
2174
2174
static bool do_trait_constant_check (
2175
2175
zend_class_entry * ce , zend_class_constant * trait_constant , zend_string * name , zend_class_entry * * traits , size_t current_trait
2176
2176
) {
2177
- bool compatible = false;
2177
+ bool is_compatible = false;
2178
2178
uint32_t flags_mask = ZEND_ACC_PPP_MASK | ZEND_ACC_FINAL ;
2179
2179
2180
2180
zval * zv = zend_hash_find_known_hash (& ce -> constants_table , name );
@@ -2188,17 +2188,17 @@ static bool do_trait_constant_check(
2188
2188
return true;
2189
2189
}
2190
2190
if ((ZEND_CLASS_CONST_FLAGS (trait_constant ) & flags_mask ) == (ZEND_CLASS_CONST_FLAGS (old_constant ) & flags_mask )) {
2191
- compatible = check_trait_property_or_constant_value_compatibility (ce , & trait_constant -> value , & old_constant -> value );
2191
+ is_compatible = check_trait_property_or_constant_value_compatibility (ce , & trait_constant -> value , & old_constant -> value );
2192
2192
}
2193
- if (!compatible ) {
2193
+ if (!is_compatible ) {
2194
2194
zend_error_noreturn (E_COMPILE_ERROR ,
2195
2195
"%s and %s define the same constant (%s) in the composition of %s. However, the definition differs and is considered incompatible. Class was composed" ,
2196
2196
ZSTR_VAL (find_first_constant_definition (ce , traits , current_trait , name , old_constant -> ce )-> name ),
2197
2197
ZSTR_VAL (trait_constant -> ce -> name ),
2198
2198
ZSTR_VAL (name ),
2199
2199
ZSTR_VAL (ce -> name ));
2200
2200
}
2201
- return compatible ;
2201
+ return is_compatible ;
2202
2202
}
2203
2203
/* }}} */
2204
2204
@@ -2267,13 +2267,13 @@ static void zend_do_traits_property_and_constant_binding(zend_class_entry *ce, z
2267
2267
zend_hash_del (& ce -> properties_info , prop_name );
2268
2268
flags |= ZEND_ACC_CHANGED ;
2269
2269
} else {
2270
- bool compatible = false;
2270
+ bool is_compatible = false;
2271
2271
uint32_t flags_mask = ZEND_ACC_PPP_MASK | ZEND_ACC_STATIC | ZEND_ACC_READONLY ;
2272
2272
2273
2273
if ((colliding_prop -> flags & flags_mask ) == (flags & flags_mask ) &&
2274
2274
property_types_compatible (property_info , colliding_prop ) == INHERITANCE_SUCCESS
2275
2275
) {
2276
- /* the flags are identical, thus, the properties may be compatible */
2276
+ /* the flags are identical, thus, the properties may be is_compatible */
2277
2277
zval * op1 , * op2 ;
2278
2278
2279
2279
if (flags & ZEND_ACC_STATIC ) {
@@ -2285,10 +2285,10 @@ static void zend_do_traits_property_and_constant_binding(zend_class_entry *ce, z
2285
2285
op1 = & ce -> default_properties_table [OBJ_PROP_TO_NUM (colliding_prop -> offset )];
2286
2286
op2 = & traits [i ]-> default_properties_table [OBJ_PROP_TO_NUM (property_info -> offset )];
2287
2287
}
2288
- compatible = check_trait_property_or_constant_value_compatibility (ce , op1 , op2 );
2288
+ is_compatible = check_trait_property_or_constant_value_compatibility (ce , op1 , op2 );
2289
2289
}
2290
2290
2291
- if (!compatible ) {
2291
+ if (!is_compatible ) {
2292
2292
zend_error_noreturn (E_COMPILE_ERROR ,
2293
2293
"%s and %s define the same property ($%s) in the composition of %s. However, the definition differs and is considered incompatible. Class was composed" ,
2294
2294
ZSTR_VAL (find_first_property_definition (ce , traits , i , prop_name , colliding_prop -> ce )-> name ),
0 commit comments