Align DOMChildNode parent checks with spec

Author: nielsdos

UPGRADING

@@ -46,6 +46,11 @@ PHP 8.3 UPGRADE NOTES
     iterating over the WeakMap (reachability via iteration is considered weak).
     Previously, such entries would never be automatically removed.
 
+- DOM:
+  . DOMChildNode::after(), DOMChildNode::before(), DOMChildNode::replaceWith()
+    on a node that has no parent is now a no-op instead of a hierarchy exception,
+    which is the behaviour spec demands.
+
 - FFI:
   . C functions that have a return type of void now return null instead of
     returning the following object object(FFI\CData:void) { }

ext/dom/parentnode.c

@@ -396,8 +396,6 @@ void dom_parent_node_after(dom_object *context, zval *nodes, uint32_t nodesc)
 	parentNode = prevsib->parent;
 	/* Spec step 2 */
 	if (!parentNode) {
-		int stricterror = dom_get_strict_error(context->document);
-		php_dom_throw_error(HIERARCHY_REQUEST_ERR, stricterror);
 		return;
 	}
 
@@ -453,8 +451,6 @@ void dom_parent_node_before(dom_object *context, zval *nodes, uint32_t nodesc)
 	parentNode = nextsib->parent;
 	/* Spec step 2 */
 	if (!parentNode) {
-		int stricterror = dom_get_strict_error(context->document);
-		php_dom_throw_error(HIERARCHY_REQUEST_ERR, stricterror);
 		return;
 	}
 
@@ -555,8 +551,6 @@ void dom_child_replace_with(dom_object *context, zval *nodes, uint32_t nodesc)
 	xmlNodePtr parentNode = child->parent;
 	/* Spec step 2 */
 	if (!parentNode) {
-		int stricterror = dom_get_strict_error(context->document);
-		php_dom_throw_error(HIERARCHY_REQUEST_ERR, stricterror);
 		return;
 	}
 

ext/dom/tests/DOMChildNode_methods_without_parent.phpt

@@ -0,0 +1,44 @@
+--TEST--
+DOMChildNode methods without a parent
+--EXTENSIONS--
+dom
+--FILE--
+<?php
+$doc = new DOMDocument;
+$doc->loadXML(<<<XML
+<?xml version="1.0"?>
+<container>
+    <child/>
+</container>
+XML);
+
+$container = $doc->documentElement;
+$child = $container->firstElementChild;
+
+$test = $doc->createElement('foo');
+foreach (['before', 'after', 'replaceWith'] as $method) {
+    echo "--- $method ---\n";
+    $test->$method($child);
+    echo $doc->saveXML();
+    echo $doc->saveXML($test), "\n";
+}
+?>
+--EXPECT--
+--- before ---
+<?xml version="1.0"?>
+<container>
+    <child/>
+</container>
+<foo/>
+--- after ---
+<?xml version="1.0"?>
+<container>
+    <child/>
+</container>
+<foo/>
+--- replaceWith ---
+<?xml version="1.0"?>
+<container>
+    <child/>
+</container>
+<foo/>