Allow fiber switching during shutdown

Author: arnaud-lb

Zend/tests/fibers/destructors_008.phpt

@@ -0,0 +1,39 @@
+--TEST--
+Fibers in destructors 008: Fibers in shutdown sequence
+--FILE--
+<?php
+
+register_shutdown_function(function () {
+    printf("Shutdown\n");
+});
+
+class C {
+    public static $instance;
+    public function __destruct() {
+        $f = new Fiber(function () {
+            printf("Started\n");
+            Fiber::suspend();
+            printf("Resumed\n");
+            Fiber::suspend();
+        });
+        $f->start();
+        $f->resume();
+        // Can not suspend main fiber
+        Fiber::suspend();
+    }
+}
+
+C::$instance = new C();
+
+?>
+--EXPECTF--
+Shutdown
+Started
+Resumed
+
+Fatal error: Uncaught FiberError: Cannot suspend outside of a fiber in %s:%d
+Stack trace:
+#0 %s(%d): Fiber::suspend()
+#1 [internal function]: C->__destruct()
+#2 {main}
+  thrown in %s on line %d

Zend/zend_objects_API.c

@@ -44,8 +44,6 @@ ZEND_API void ZEND_FASTCALL zend_objects_store_call_destructors(zend_objects_sto
 {
 	EG(flags) |= EG_FLAGS_OBJECT_STORE_NO_REUSE;
 	if (objects->top > 1) {
-		zend_fiber_switch_block();
-
 		uint32_t i;
 		for (i = 1; i < objects->top; i++) {
 			zend_object *obj = objects->object_buckets[i];
@@ -62,8 +60,6 @@ ZEND_API void ZEND_FASTCALL zend_objects_store_call_destructors(zend_objects_sto
 				}
 			}
 		}
-
-		zend_fiber_switch_unblock();
 	}
 }