Fix persisting of inherited class constants

Class constants are inherited to user classes without cloning. Thus, internal
class constants should not be persisted at all. Simply keep pointing to the
internal class constant.

Fixes GH-14109

Author: iluuu1994

ext/opcache/zend_persist.c

@@ -923,7 +923,26 @@ zend_class_entry *zend_persist_class_entry(zend_class_entry *orig_ce)
 		ZEND_HASH_MAP_FOREACH_BUCKET(&ce->constants_table, p) {
 			ZEND_ASSERT(p->key != NULL);
 			zend_accel_store_interned_string(p->key);
-			zend_persist_class_constant(&p->val);
+
+			zend_class_constant *c = Z_PTR(p->val);
+			if (c->ce == orig_ce || (Z_CONSTANT_FLAGS(c->value) & CONST_OWNED)) {
+				zend_persist_class_constant(&p->val);
+			} else {
+				zend_class_constant *new_c = zend_shared_alloc_get_xlat_entry(c);
+				if (new_c) {
+					Z_PTR(p->val) = new_c;
+				} else {
+#ifndef ZEND_WIN32
+					/* Internal class constant, keep the pointer to the old one. */
+					ZEND_ASSERT(c->ce->type == ZEND_INTERNAL_CLASS);
+#else
+					/* Windows must not persist linked classes with internal parents. We must not
+					 * point to internal structures in shm on Windows, because they might live in
+					 * different places for each process. */
+					ZEND_UNREACHABLE();
+#endif
+				}
+			}
 		} ZEND_HASH_FOREACH_END();
 		HT_FLAGS(&ce->constants_table) &= (HASH_FLAG_UNINITIALIZED | HASH_FLAG_STATIC_KEYS);
 

ext/opcache/zend_persist_calc.c

@@ -26,6 +26,7 @@
 #include "zend_shared_alloc.h"
 #include "zend_operators.h"
 #include "zend_attributes.h"
+#include "zend_constants.h"
 
 #define ADD_DUP_SIZE(m,s)  ZCG(current_persistent_script)->size += zend_shared_memdup_size((void*)m, s)
 #define ADD_SIZE(m)        ZCG(current_persistent_script)->size += ZEND_ALIGNED_SIZE(m)
@@ -451,7 +452,11 @@ void zend_persist_class_entry_calc(zend_class_entry *ce)
 		ZEND_HASH_MAP_FOREACH_BUCKET(&ce->constants_table, p) {
 			ZEND_ASSERT(p->key != NULL);
 			ADD_INTERNED_STRING(p->key);
-			zend_persist_class_constant_calc(&p->val);
+
+			zend_class_constant *c = Z_PTR(p->val);
+			if (c->ce == ce || (Z_CONSTANT_FLAGS(c->value) & CONST_OWNED)) {
+				zend_persist_class_constant_calc(&p->val);
+			}
 		} ZEND_HASH_FOREACH_END();
 
 		zend_hash_persist_calc(&ce->properties_info);

ext/zend_test/tests/gh14109.phpt

@@ -0,0 +1,16 @@
+--TEST--
+GH-14109: User class extending internal class with attributes
+--EXTENSIONS--
+zend_test
+--FILE--
+<?php
+class Test extends ZendAttributeTest {}
+foreach ((new ReflectionClassConstant(Test::class, 'TEST_CONST'))->getAttributes() as $attribute) {
+    var_dump($attribute->newInstance());
+}
+?>
+--EXPECTF--
+object(ZendTestRepeatableAttribute)#%d (0) {
+}
+object(ZendTestRepeatableAttribute)#%d (0) {
+}