Throw notice on param name mismatch

Author: nikic

Zend/zend_inheritance.c

@@ -516,6 +516,18 @@ static inheritance_status zend_do_perform_arg_type_hint_check(
 }
 /* }}} */
 
+static const char *get_arg_name(
+		const zend_function *fe, const zend_arg_info *arg_info, size_t *len) {
+	if (fe->type == ZEND_INTERNAL_FUNCTION) {
+		zend_internal_arg_info *internal_arg_info = (zend_internal_arg_info *) arg_info;
+		*len = strlen(internal_arg_info->name);
+		return internal_arg_info->name;
+	} else {
+		*len = ZSTR_LEN(arg_info->name);
+		return ZSTR_VAL(arg_info->name);
+	}
+}
+
 static inheritance_status zend_do_perform_implementation_check(
 		const zend_function *fe, const zend_function *proto) /* {{{ */
 {
@@ -592,6 +604,20 @@ static inheritance_status zend_do_perform_implementation_check(
 		if (ZEND_ARG_SEND_MODE(fe_arg_info) != ZEND_ARG_SEND_MODE(proto_arg_info)) {
 			return INHERITANCE_ERROR;
 		}
+
+		// TODO: We may get duplicate errors for UNRESOLVED.
+		size_t proto_name_len, fe_name_len;
+		const char *proto_name = get_arg_name(proto, proto_arg_info, &proto_name_len);
+		const char *fe_name = get_arg_name(fe, fe_arg_info, &fe_name_len);
+		if (proto_name_len != fe_name_len || memcmp(proto_name, fe_name, proto_name_len)) {
+			zend_error(E_NOTICE,
+				"Parameter $%s of %s::%s() has been renamed to $%s in %s::%s(), "
+				"which may break named parameters",
+				proto_name,
+				ZSTR_VAL(proto->common.scope->name), ZSTR_VAL(proto->common.function_name),
+				fe_name,
+				ZSTR_VAL(fe->common.scope->name), ZSTR_VAL(fe->common.function_name));
+		}
 	}
 
 	/* Check return type compatibility, but only if the prototype already specifies