Merge branch 'PHP-7.2' into PHP-7.3

Author: nikic

NEWS

@@ -37,6 +37,7 @@ PHP                                                                        NEWS
 
 - Reflection:
   . Fixed bug #77772 (ReflectionClass::getMethods(null) doesn't work). (Nikita)
+  . Fixed bug #77882 (Different behavior: always calls destructor). (Nikita)
 
 - Standard:
   . Fixed bug #77793 (Segmentation fault in extract() when overwriting

ext/reflection/php_reflection.c

@@ -4720,6 +4720,10 @@ ZEND_METHOD(reflection_class, newInstance)
 		for (i = 0; i < num_args; i++) {
 			zval_ptr_dtor(&params[i]);
 		}
+
+		if (EG(exception)) {
+			zend_object_store_ctor_failed(Z_OBJ_P(return_value));
+		}
 		if (ret == FAILURE) {
 			php_error_docref(NULL, E_WARNING, "Invocation of %s's constructor failed", ZSTR_VAL(ce->name));
 			zval_ptr_dtor(return_value);
@@ -4820,6 +4824,10 @@ ZEND_METHOD(reflection_class, newInstanceArgs)
 			}
 			efree(params);
 		}
+
+		if (EG(exception)) {
+			zend_object_store_ctor_failed(Z_OBJ_P(return_value));
+		}
 		if (ret == FAILURE) {
 			zval_ptr_dtor(&retval);
 			php_error_docref(NULL, E_WARNING, "Invocation of %s's constructor failed", ZSTR_VAL(ce->name));

ext/reflection/tests/bug77882.phpt

@@ -0,0 +1,38 @@
+--TEST--
+Bug #77882: Different behavior: always calls destructor
+--FILE--
+<?php
+
+class Test {
+    public function __construct() {
+        throw new Exception();
+    }
+    
+    public function __destruct() {
+        echo "__destruct\n";
+    }
+}
+
+try {
+    new Test();
+} catch (Exception $e) {
+    echo "Exception\n";
+}
+try {
+    $ref = new ReflectionClass('Test');
+    $obj = $ref->newInstance();
+} catch (Exception $e) {
+    echo "Exception\n";
+}
+try {
+    $ref = new ReflectionClass('Test');
+    $obj = $ref->newInstanceArgs([]);
+} catch (Exception $e) {
+    echo "Exception\n";
+}
+
+?>
+--EXPECT--
+Exception
+Exception
+Exception