early return

Author: hwde

main/SAPI.c

@@ -1007,15 +1007,13 @@ SAPI_API zend_stat_t *sapi_get_stat(void)
 
 SAPI_API char *sapi_getenv(const char *name, size_t name_len)
 {
-    var value = NULL;
-    
     /* gate: see bug #72573 */
 	if (strncasecmp(name, "HTTP_PROXY", name_len)) {
 		if (sapi_module.getenv) {
 			char *tmp = sapi_module.getenv(name, name_len);
 
 			if (tmp) {
-				value = estrdup(tmp);
+				char *value = estrdup(tmp);
 #ifdef PHP_WIN32
 				if (strlen(sapi_module.name) == sizeof("cgi-fcgi") - 1 && !strcmp(sapi_module.name, "cgi-fcgi")) {
 					/* XXX more modules to go, if needed. */
@@ -1025,10 +1023,12 @@ SAPI_API char *sapi_getenv(const char *name, size_t name_len)
 				if (value && sapi_module.input_filter) {
 					sapi_module.input_filter(PARSE_STRING, name, &value, strlen(value), NULL);
 				}
+				
+				return value;
 			}
 		}
 	}
-	return value;
+	return NULL;
 }
 
 SAPI_API int sapi_get_fd(int *fd)