fix: pgsqlSetNoticeCallback: ADDREF on non ref counted

outtersg · outtersg · commit 12fc06020898 · 2020-01-09T20:29:15.000+01:00
Core dumped when using a string callable.
diff --git a/ext/pdo_pgsql/pgsql_driver.c b/ext/pdo_pgsql/pgsql_driver.c
@@ -1193,7 +1193,7 @@ static PHP_METHOD(PDO, pgsqlSetNoticeCallback)
 			H->notice_callback = NULL;
 			RETURN_FALSE;
 		}
-		Z_ADDREF_P(&fc->fci.function_name);
+		Z_TRY_ADDREF_P(&fc->fci.function_name);
 		zend_string_release_ex(cbname, 0);
 
 		H->notice_callback = fc;

Original file line number	Diff line number	Diff line change
`@@ -1193,7 +1193,7 @@ static PHP_METHOD(PDO, pgsqlSetNoticeCallback)`
`1193`	`1193`	`H->notice_callback = NULL;`
`1194`	`1194`	`RETURN_FALSE;`
`1195`	`1195`	`}`
`1196`		`- Z_ADDREF_P(&fc->fci.function_name);`
	`1196`	`+ Z_TRY_ADDREF_P(&fc->fci.function_name);`
`1197`	`1197`	`zend_string_release_ex(cbname, 0);`
`1198`	`1198`
`1199`	`1199`	`H->notice_callback = fc;`