jit: fixed JIT "Attempt to assign property of non-object" warning emitted at the same time as Error is being thrown

Author: Girgias

NEWS

@@ -32,6 +32,8 @@ PHP                                                                        NEWS
 - Opcache:
   . Fixed JIT bug (Function JIT emits "Uninitialized string offset" warning
     at the same time as invalid offset Error). (Girgias)
+  . Fixed JIT bug (JIT emits "Attempt to assign property of non-object"
+    warning at the same time as Error is being thrown). (Girgias)
 
 - OpenSSL:
   . Fixed bug #50713 (openssl_pkcs7_verify() may ignore untrusted CAs).

ext/opcache/jit/zend_jit_helpers.c

@@ -1591,7 +1591,9 @@ static void ZEND_FASTCALL zend_jit_assign_dim_op_helper(zval *container, zval *d
 			}
 			zval_ptr_dtor(&res);
 		} else {
-			zend_error(E_WARNING, "Attempt to assign property of non-object");
+			/* Exception is thrown in this case */
+			GC_DELREF(obj);
+			return;
 		}
 		if (UNEXPECTED(GC_DELREF(obj) == 0)) {
 			zend_objects_store_del(obj);

ext/opcache/tests/jit/gh12723-B.phpt

@@ -0,0 +1,19 @@
+--TEST--
+GH-12723: JIT emits "Attempt to assign property of non-object" warning at the same time as Error is being thrown
+--INI--
+opcache.enable=1
+opcache.enable_cli=1
+--FILE--
+<?php
+
+$container = new stdClass();
+
+try {
+    $container[new stdClass()] .= 'append';
+} catch (\Throwable $e) {
+    echo $e->getMessage(), "\n";
+}
+
+?>
+--EXPECT--
+Cannot use object of type stdClass as array