Skip to content

Commit 111372b

Browse files
committed
Autotools: Use FPM_EXTRA_LIBS for apparmor library
Instead of appending -lapparmor to global LIBS variable, this adds it as needed only to FPM_EXTRA_LIBS as it was already used in the BUILD_FPM invocation. Follow-up of GH-14881
1 parent 64c7c4c commit 111372b

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

sapi/fpm/config.m4

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -436,7 +436,8 @@ if test "$PHP_FPM" != "no"; then
436436
[no],
437437
[no])
438438

439-
PHP_ARG_WITH([fpm-apparmor],,
439+
PHP_ARG_WITH([fpm-apparmor],
440+
[whether to enable AppArmor confinement in PHP-FPM],
440441
[AS_HELP_STRING([--with-fpm-apparmor],
441442
[Support AppArmor confinement through libapparmor])],
442443
[no],
@@ -493,23 +494,27 @@ if test "$PHP_FPM" != "no"; then
493494
])
494495
fi
495496

496-
if test "x$PHP_FPM_APPARMOR" != "xno" ; then
497+
AS_VAR_IF([PHP_FPM_APPARMOR], [no],, [
498+
ext_shared_save=$ext_shared
499+
ext_shared=yes
497500
PKG_CHECK_MODULES([APPARMOR], [libapparmor], [
498-
PHP_EVAL_LIBLINE([$APPARMOR_LIBS])
501+
PHP_EVAL_LIBLINE([$APPARMOR_LIBS], [FPM_EXTRA_LIBS])
499502
PHP_EVAL_INCLINE([$APPARMOR_CFLAGS])
500503
],
501504
[AC_CHECK_LIB([apparmor], [aa_change_profile],
502505
[PHP_ADD_LIBRARY([apparmor])],
503506
[AC_MSG_ERROR([libapparmor required but not found.])])])
507+
ext_shared=$ext_shared_save
504508
505509
dnl Sanity check.
506-
CFLAGS_save="$CFLAGS"
510+
CFLAGS_save=$CFLAGS
507511
CFLAGS="$INCLUDES $CFLAGS"
508512
AC_CHECK_HEADER([sys/apparmor.h],
509-
[AC_DEFINE([HAVE_APPARMOR], [1], [AppArmor confinement available])],
513+
[AC_DEFINE([HAVE_APPARMOR], [1],
514+
[Define to 1 if AppArmor confinement is available for PHP-FPM.])],
510515
[AC_MSG_ERROR([Required sys/apparmor.h not found.])])
511-
CFLAGS="$CFLAGS_save"
512-
fi
516+
CFLAGS=$CFLAGS_save
517+
])
513518

514519
if test "x$PHP_FPM_SELINUX" != "xno" ; then
515520
PKG_CHECK_MODULES([SELINUX], [libselinux], [
@@ -611,4 +616,5 @@ if test "$PHP_FPM" != "no"; then
611616

612617
PHP_SUBST([SAPI_FPM_PATH])
613618
PHP_SUBST([BUILD_FPM])
619+
PHP_SUBST([FPM_EXTRA_LIBS])
614620
fi

0 commit comments

Comments
 (0)