Add warning when trying to perform binop on unsupported types

Author: Girgias

ext/standard/array.c

@@ -5935,7 +5935,8 @@ PHP_FUNCTION(array_sum)
 				ZVAL_LONG(&tmp, 0);
 				add_function(return_value, return_value, &tmp);
 			}
-			// TODO Warning/Deprecation?
+			php_error_docref(NULL, E_WARNING, "Addition is not supported on type %s",
+				zend_zval_type_name(entry));
 		}
 	} ZEND_HASH_FOREACH_END();
 
@@ -5992,7 +5993,8 @@ PHP_FUNCTION(array_product)
 				ZVAL_LONG(&tmp, 0);
 				mul_function(return_value, return_value, &tmp);
 			}
-			// TODO Warning/Deprecation?
+			php_error_docref(NULL, E_WARNING, "Multiplication is not supported on type %s",
+				zend_zval_type_name(entry));
 		}
 	} ZEND_HASH_FOREACH_END();
 

ext/standard/tests/array/003.phpt

@@ -8,27 +8,27 @@ require(__DIR__ . '/data.inc');
 
 function cmp ($a, $b) {
     is_array ($a)
-        and $a = array_sum ($a);
+        and $a = count($a);
     is_array ($b)
-        and $b = array_sum ($b);
+        and $b = count($b);
     return strcmp ($a, $b);
 }
 
-echo " -- Testing uasort() -- \n";
+echo "-- Testing uasort() --\n";
 uasort ($data, 'cmp');
 var_dump ($data);
 
 
-echo "\n -- Testing uksort() -- \n";
+echo "\n-- Testing uksort() --\n";
 uksort ($data, 'cmp');
 var_dump ($data);
 
-echo "\n -- Testing usort() -- \n";
+echo "\n-- Testing usort() --\n";
 usort ($data, 'cmp');
 var_dump ($data);
 ?>
 --EXPECT--
--- Testing uasort() -- 
+-- Testing uasort() --
 array(8) {
   [16777216]=>
   float(-0.3333333333333333)
@@ -53,7 +53,7 @@ array(8) {
   string(4) "test"
 }
 
- -- Testing uksort() -- 
+-- Testing uksort() --
 array(8) {
   [-1000]=>
   array(2) {
@@ -78,7 +78,7 @@ array(8) {
   int(27)
 }
 
- -- Testing usort() -- 
+-- Testing usort() --
 array(8) {
   [0]=>
   float(-0.3333333333333333)

ext/standard/tests/array/array_product_variation1.phpt

@@ -20,7 +20,7 @@ foreach ($types as $desc => $type) {
 }
 
 ?>
---EXPECT--
+--EXPECTF--
 *** Testing array_product() : variation - using non numeric values ***
 boolean (true)
 int(1)
@@ -29,20 +29,28 @@ boolean (false)
 int(0)
 
 string
+
+Warning: array_product(): Multiplication is not supported on type string in %s on line %d
 int(0)
 
 numeric string
 int(12)
 
 resource
+
+Warning: array_product(): Multiplication is not supported on type resource in %s on line %d
 int(3)
 
 object
+
+Warning: array_product(): Multiplication is not supported on type A in %s on line %d
 int(1)
 
 null
 int(0)
 
 array
+
+Warning: array_product(): Multiplication is not supported on type array in %s on line %d
 int(1)
 

ext/standard/tests/array/array_product_variation5.phpt

@@ -5,5 +5,6 @@ Test array_product() function: ressources in array
 $input = [10, STDERR /* Should get casted to 3 as an integer */];
 var_dump(array_product($input));
 ?>
---EXPECT--
+--EXPECTF--
+Warning: array_product(): Multiplication is not supported on type resource in %s on line %d
 int(30)

ext/standard/tests/array/array_sum_variation7.phpt

@@ -57,18 +57,48 @@ echo "-- array with mixed values --\n";
 var_dump( array_sum($input) );
 echo "Done"
 ?>
---EXPECT--
+--EXPECTF--
 *** Testing array_sum() : array with unexpected entries ***
 -- array with string values --
+
+Warning: array_sum(): Addition is not supported on type string in %s on line %d
+
+Warning: array_sum(): Addition is not supported on type string in %s on line %d
+
+Warning: array_sum(): Addition is not supported on type string in %s on line %d
+
+Warning: array_sum(): Addition is not supported on type string in %s on line %d
+
+Warning: array_sum(): Addition is not supported on type string in %s on line %d
 int(0)
 -- array with bool values --
 int(3)
 -- array with null values --
 int(0)
 -- array with subarrays --
+
+Warning: array_sum(): Addition is not supported on type array in %s on line %d
+
+Warning: array_sum(): Addition is not supported on type array in %s on line %d
+
+Warning: array_sum(): Addition is not supported on type array in %s on line %d
 int(0)
 -- array with object values --
+
+Warning: array_sum(): Addition is not supported on type MyClass in %s on line %d
+
+Warning: array_sum(): Addition is not supported on type MyClass in %s on line %d
+
+Warning: array_sum(): Addition is not supported on type MyClass in %s on line %d
+
+Warning: array_sum(): Addition is not supported on type MyClass in %s on line %d
 int(0)
 -- array with mixed values --
+
+Warning: array_sum(): Addition is not supported on type string in %s on line %d
+
+Warning: array_sum(): Addition is not supported on type string in %s on line %d
+
+Warning: array_sum(): Addition is not supported on type array in %s on line %d
 float(14)
 Done

ext/standard/tests/array/array_sum_variation8.phpt

@@ -5,5 +5,6 @@ Test array_sum() function: ressources in array
 $input = [10, STDERR /* Should get casted to 3 as an integer */];
 var_dump(array_sum($input));
 ?>
---EXPECT--
+--EXPECTF--
+Warning: array_sum(): Addition is not supported on type resource in %s on line %d
 int(13)