... or we re-establish empty domain check.

Author: devnexen

ext/gettext/gettext.c

@@ -190,6 +190,11 @@ PHP_FUNCTION(bindtextdomain)
 
 	PHP_GETTEXT_DOMAIN_LENGTH_CHECK(1, ZSTR_LEN(domain))
 
+	if (ZSTR_VAL(domain)[0] == '\0') {
+		zend_argument_value_error(1, "cannot be empty");
+		RETURN_THROWS();
+	}
+
 	if (dir == NULL) {
 		btd_result = bindtextdomain(ZSTR_VAL(domain), NULL);
 		if (btd_result == NULL) {
@@ -212,9 +217,6 @@ PHP_FUNCTION(bindtextdomain)
 	}
 
 	retval = bindtextdomain(ZSTR_VAL(domain), dir_name);
-	if (retval == NULL) {
-		RETURN_FALSE;
-	}
 
 	RETURN_STRING(retval);
 }