Skip to content

Commit 0e50b96

Browse files
committed
When charset_no is 0, 255 is now used as the default value.
1 parent 2f60582 commit 0e50b96

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

ext/mysqlnd/mysqlnd_charset.h

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,8 @@
1919
#ifndef MYSQLND_CHARSET_H
2020
#define MYSQLND_CHARSET_H
2121

22+
#define MYSQLND_DEFAULT_PROTOCOL_CHARSET 255
23+
2224
PHPAPI zend_ulong mysqlnd_cset_escape_quotes(const MYSQLND_CHARSET * const charset, char * newstr,
2325
const char * escapestr, const size_t escapestr_len);
2426

ext/mysqlnd/mysqlnd_commands.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
#include "mysqlnd_auth.h"
2323
#include "mysqlnd_wireprotocol.h"
2424
#include "mysqlnd_debug.h"
25+
#include "mysqlnd_charset.h"
2526

2627

2728
/* {{{ mysqlnd_command::set_option */
@@ -642,7 +643,7 @@ MYSQLND_METHOD(mysqlnd_command, handshake)(MYSQLND_CONN_DATA * const conn, const
642643
conn->protocol_version = greet_packet.protocol_version;
643644
conn->server_version = mnd_pestrdup(greet_packet.server_version, conn->persistent);
644645

645-
conn->greet_charset = mysqlnd_find_charset_nr(greet_packet.charset_no);
646+
conn->greet_charset = mysqlnd_find_charset_nr(greet_packet.charset_no != 0 ? greet_packet.charset_no : MYSQLND_DEFAULT_PROTOCOL_CHARSET);
646647
if (!conn->greet_charset) {
647648
char * msg;
648649
mnd_sprintf(&msg, 0, "Server sent charset (%d) unknown to the client. Please, report to the developers", greet_packet.charset_no);

0 commit comments

Comments
 (0)