return or die

cmb69 · kamil-tekiela · cmb69 · commit 0e334fe1ea12 · 2024-08-18T11:36:45.000+02:00
Co-authored-by: Kamil Tekiela &lt;tekiela246@gmail.com&gt;
diff --git a/ext/mysqli/tests/test_setup/test_helpers.inc b/ext/mysqli/tests/test_setup/test_helpers.inc
@@ -112,11 +112,10 @@ function mysqli_check_skip_test(): void {
 }
 function mysqli_connect_or_skip() {
     try {
-        default_mysqli_connect();
+        return default_mysqli_connect();
     } catch (\mysqli_sql_exception) {
         die(sprintf("skip Can't connect to MySQL Server - [%d] %s", mysqli_connect_errno(), mysqli_connect_error()));
     }
-    return $link;
 }
 function have_innodb(mysqli $link): bool {
     $res = $link->query("SELECT SUPPORT FROM INFORMATION_SCHEMA.ENGINES WHERE ENGINE = 'InnoDB'");

Original file line number	Diff line number	Diff line change
`@@ -112,11 +112,10 @@ function mysqli_check_skip_test(): void {`
`112`	`112`	`}`
`113`	`113`	`function mysqli_connect_or_skip() {`
`114`	`114`	`try {`
`115`		`- default_mysqli_connect();`
	`115`	`+ return default_mysqli_connect();`
`116`	`116`	`} catch (\mysqli_sql_exception) {`
`117`	`117`	`die(sprintf("skip Can't connect to MySQL Server - [%d] %s", mysqli_connect_errno(), mysqli_connect_error()));`
`118`	`118`	`}`
`119`		`- return $link;`
`120`	`119`	`}`
`121`	`120`	`function have_innodb(mysqli $link): bool {`
`122`	`121`	`$res = $link->query("SELECT SUPPORT FROM INFORMATION_SCHEMA.ENGINES WHERE ENGINE = 'InnoDB'");`