Optimized bit shifting

SakiTakamachi · SakiTakamachi · commit 0d419cc75777 · 2024-07-22T22:26:59.000+09:00
diff --git a/ext/random/randomizer.c b/ext/random/randomizer.c
@@ -298,8 +298,10 @@ PHP_METHOD(Random_Randomizer, getBytes)
 			zend_string_free(retval);
 			RETURN_THROWS();
 		}
+		uint64_t tmp_ret = result.result;
 		for (size_t i = 0; i < result.size; i++) {
-			ZSTR_VAL(retval)[total_size++] = (result.result >> (i * 8)) & 0xff;
+			ZSTR_VAL(retval)[total_size++] = tmp_ret & 0xff;
+			tmp_ret >>= 8;
 			if (total_size >= length) {
 				break;
 			}

Original file line number	Diff line number	Diff line change
`@@ -298,8 +298,10 @@ PHP_METHOD(Random_Randomizer, getBytes)`
`298`	`298`	`zend_string_free(retval);`
`299`	`299`	`RETURN_THROWS();`
`300`	`300`	`}`
	`301`	`+ uint64_t tmp_ret = result.result;`
`301`	`302`	`for (size_t i = 0; i < result.size; i++) {`
`302`		`- ZSTR_VAL(retval)[total_size++] = (result.result >> (i * 8)) & 0xff;`
	`303`	`+ ZSTR_VAL(retval)[total_size++] = tmp_ret & 0xff;`
	`304`	`+ tmp_ret >>= 8;`
`303`	`305`	`if (total_size >= length) {`
`304`	`306`	`break;`
`305`	`307`	`}`