Add zend_ulong_to_str() API

No point in going through a smart_str and append_unsigned if we
can construct the result directly...

Author: nikic

Zend/zend_operators.c

@@ -3044,6 +3044,17 @@ ZEND_API zend_string* ZEND_FASTCALL zend_long_to_str(zend_long num) /* {{{ */
 }
 /* }}} */
 
+ZEND_API zend_string* ZEND_FASTCALL zend_ulong_to_str(zend_ulong num)
+{
+	if (num <= 9) {
+		return ZSTR_CHAR((zend_uchar)'0' + (zend_uchar)num);
+	} else {
+		char buf[MAX_LENGTH_OF_LONG + 1];
+		char *res = zend_print_ulong_to_buf(buf + sizeof(buf) - 1, num);
+		return zend_string_init(res, buf + sizeof(buf) - 1 - res, 0);
+	}
+}
+
 /* buf points to the END of the buffer */
 static zend_always_inline char *zend_print_u64_to_buf(char *buf, uint64_t num64) {
 #if SIZEOF_ZEND_LONG == 8

Zend/zend_operators.h

@@ -876,6 +876,7 @@ static zend_always_inline char *zend_print_long_to_buf(char *buf, zend_long num)
 }
 
 ZEND_API zend_string* ZEND_FASTCALL zend_long_to_str(zend_long num);
+ZEND_API zend_string* ZEND_FASTCALL zend_ulong_to_str(zend_ulong num);
 ZEND_API zend_string* ZEND_FASTCALL zend_u64_to_str(uint64_t num);
 ZEND_API zend_string* ZEND_FASTCALL zend_i64_to_str(int64_t num);
 

ext/pgsql/pgsql.c

@@ -64,10 +64,7 @@
 #if ZEND_LONG_MAX < UINT_MAX
 #define PGSQL_RETURN_OID(oid) do { \
 	if (oid > ZEND_LONG_MAX) { \
-		smart_str s = {0}; \
-		smart_str_append_unsigned(&s, oid); \
-		smart_str_0(&s); \
-		RETURN_NEW_STR(s.s); \
+		RETURN_STR(zend_ulong_to_str(oid)); \
 	} \
 	RETURN_LONG((zend_long)oid); \
 } while(0)