Call to zend_ssa_unlink_use_chain() shouldn't be dropped

dstogov · dstogov · commit 0b64d71109fd · 2017-07-14T11:14:40.000+03:00
diff --git a/ext/opcache/Optimizer/dfa_pass.c b/ext/opcache/Optimizer/dfa_pass.c
@@ -634,7 +634,7 @@ void zend_dfa_optimize_op_array(zend_op_array *op_array, zend_optimizer_ctx *ctx
 // op_1: ASSIGN #orig_var.CV [undef,scalar] -> #v.CV, CONST|TMPVAR => QM_ASSIGN v.CV, CONST|TMPVAR
 
 						if (ssa->ops[op_1].op1_use != ssa->ops[op_1].op2_use) {
-							ZEND_ASSERT(zend_ssa_unlink_use_chain(ssa, op_1, orig_var));
+							zend_ssa_unlink_use_chain(ssa, op_1, orig_var);
 						} else {
 							ssa->ops[op_1].op2_use_chain = ssa->ops[op_1].op1_use_chain;
 						}

Original file line number	Diff line number	Diff line change
`@@ -634,7 +634,7 @@ void zend_dfa_optimize_op_array(zend_op_array op_array, zend_optimizer_ctx ctx`
`634`	`634`	`// op_1: ASSIGN #orig_var.CV [undef,scalar] -> #v.CV, CONST\|TMPVAR => QM_ASSIGN v.CV, CONST\|TMPVAR`
`635`	`635`
`636`	`636`	`if (ssa->ops[op_1].op1_use != ssa->ops[op_1].op2_use) {`
`637`		`- ZEND_ASSERT(zend_ssa_unlink_use_chain(ssa, op_1, orig_var));`
	`637`	`+ zend_ssa_unlink_use_chain(ssa, op_1, orig_var);`
`638`	`638`	`} else {`
`639`	`639`	`ssa->ops[op_1].op2_use_chain = ssa->ops[op_1].op1_use_chain;`
`640`	`640`	`}`