Log a warning when opcache lock file permissions could not be changed

TaaviE · nielsdos · commit 0a8961a0e26e · 2025-06-03T19:22:58.000+02:00
Closes GH-18742.
diff --git a/NEWS b/NEWS
@@ -121,6 +121,8 @@ PHP                                                                        NEWS
   . Fixed ZTS OPcache build on Cygwin. (cmb)
   . Added opcache.file_cache_read_only. (Samuel Melrose)
   . Updated default value of opcache.jit_hot_loop. (Arnaud)
+  . Log a warning when opcache lock file permissions could not be changed.
+    (Taavi Eomäe)
 
 - Output:
   . Fixed calculation of aligned buffer size. (cmb)
diff --git a/ext/opcache/zend_shared_alloc.c b/ext/opcache/zend_shared_alloc.c
@@ -115,7 +115,9 @@ void zend_shared_alloc_create_lock(char *lockfile_path)
 		zend_accel_error_noreturn(ACCEL_LOG_FATAL, "Unable to create opcache lock file in %s: %s (%d)", lockfile_path, strerror(errno), errno);
 	}
 
-	fchmod(lock_file, 0666);
+	if (fchmod(lock_file, 0666) == -1) {
+		zend_accel_error(ACCEL_LOG_WARNING, "Unable to change opcache lock file permissions in %s: %s (%d)", lockfile_path, strerror(errno), errno);
+	}
 
 	val = fcntl(lock_file, F_GETFD, 0);
 	val |= FD_CLOEXEC;

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,9 @@ void zend_shared_alloc_create_lock(char *lockfile_path)`
`115`	`115`	`zend_accel_error_noreturn(ACCEL_LOG_FATAL, "Unable to create opcache lock file in %s: %s (%d)", lockfile_path, strerror(errno), errno);`
`116`	`116`	`}`
`117`	`117`
`118`		`- fchmod(lock_file, 0666);`
	`118`	`+ if (fchmod(lock_file, 0666) == -1) {`
	`119`	`+ zend_accel_error(ACCEL_LOG_WARNING, "Unable to change opcache lock file permissions in %s: %s (%d)", lockfile_path, strerror(errno), errno);`
	`120`	`+ }`
`119`	`121`
`120`	`122`	`val = fcntl(lock_file, F_GETFD, 0);`
`121`	`123`	`val \|= FD_CLOEXEC;`