Get rid of redundant code

nielsdos · nielsdos · commit 076464d31b5e · 2024-06-02T19:32:54.000+02:00
This isn't reachable since ab32d36
diff --git a/ext/pcre/php_pcre.c b/ext/pcre/php_pcre.c
@@ -568,11 +568,6 @@ static zend_string **make_subpats_table(uint32_t name_cnt, pcre_cache_entry *pce
 		if (persistent) {
 			GC_MAKE_PERSISTENT_LOCAL(subpat_names[name_idx]);
 		}
-		if (is_numeric_string(ZSTR_VAL(subpat_names[name_idx]), ZSTR_LEN(subpat_names[name_idx]), NULL, NULL, 0) > 0) {
-			php_error_docref(NULL, E_WARNING, "Numeric named subpatterns are not allowed");
-			free_subpats_table(subpat_names, num_subpats, persistent);
-			return NULL;
-		}
 		name_table += name_size;
 	}
 	return subpat_names;

Original file line number	Diff line number	Diff line change
`@@ -568,11 +568,6 @@ static zend_string *make_subpats_table(uint32_t name_cnt, pcre_cache_entry pce`
`568`	`568`	`if (persistent) {`
`569`	`569`	`GC_MAKE_PERSISTENT_LOCAL(subpat_names[name_idx]);`
`570`	`570`	`}`
`571`		`- if (is_numeric_string(ZSTR_VAL(subpat_names[name_idx]), ZSTR_LEN(subpat_names[name_idx]), NULL, NULL, 0) > 0) {`
`572`		`- php_error_docref(NULL, E_WARNING, "Numeric named subpatterns are not allowed");`
`573`		`- free_subpats_table(subpat_names, num_subpats, persistent);`
`574`		`- return NULL;`
`575`		`- }`
`576`	`571`	`name_table += name_size;`
`577`	`572`	`}`
`578`	`573`	`return subpat_names;`