Skip to content

Commit 076414b

Browse files
committed
Drop comments for flock()
1 parent 1c57b65 commit 076414b

File tree

2 files changed

+0
-4
lines changed

2 files changed

+0
-4
lines changed

ext/spl/spl_directory.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2511,8 +2511,6 @@ PHP_METHOD(SplFileObject, flock)
25112511
CHECK_SPL_FILE_OBJECT_IS_INITIALIZED(intern);
25122512

25132513
act = operation & PHP_LOCK_UN;
2514-
// TODO doesn't this fail if operation is a bitmask with LOCK_NB?
2515-
//if (act != PHP_LOCK_SH && act != PHP_LOCK_EX && act != PHP_LOCK_UN) {
25162514
if (act < 1 || act > 3) {
25172515
zend_argument_value_error(1, "must be either LOCK_SH, LOCK_EX, or LOCK_UN");
25182516
RETURN_THROWS();

ext/standard/file.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -345,8 +345,6 @@ PHP_FUNCTION(flock)
345345
PHP_STREAM_TO_ZVAL(stream, res);
346346

347347
act = operation & PHP_LOCK_UN;
348-
// TODO doesn't this fail if operation is a bitmask with LOCK_NB?
349-
//if (act != PHP_LOCK_SH && act != PHP_LOCK_EX && act != PHP_LOCK_UN) {
350348
if (act < 1 || act > 3) {
351349
zend_argument_value_error(2, "must be either LOCK_SH, LOCK_EX, or LOCK_UN");
352350
RETURN_THROWS();

0 commit comments

Comments
 (0)