Use zend_string_alloc directly

Hasn't been tested so this is a shot in the dark

Author: Girgias

ext/pdo_dblib/dblib_driver.c

@@ -147,7 +147,7 @@ static zend_string* dblib_handle_quoter(pdo_dbh_t *dbh, const zend_string *unquo
 	pdo_dblib_db_handle *H = (pdo_dblib_db_handle *)dbh->driver_data;
 	zend_bool use_national_character_set = 0;
 	size_t i;
-	char *q, *quoted;
+	char *q;
 	size_t quotedlen = 0;
 	zend_string *quoted_str;
 
@@ -171,7 +171,8 @@ static zend_string* dblib_handle_quoter(pdo_dbh_t *dbh, const zend_string *unquo
 	if (use_national_character_set) {
 		++quotedlen; /* N prefix */
 	}
-	q = quoted = emalloc(quotedlen + 1); /* Add byte for terminal null */
+	quoted_str = zend_string_alloc(quotedlen, 0);
+	q = ZSTR_VAL(quoted_str);
 	if (use_national_character_set) {
 		*q++ = 'N';
 	}
@@ -185,16 +186,12 @@ static zend_string* dblib_handle_quoter(pdo_dbh_t *dbh, const zend_string *unquo
 			*q++ = ZSTR_VAL(unquoted)[i];
 		}
 	}
-	*q++ = '\'';
-
-	*q = 0;
+	*q = '\'';
 
-	quoted_str = zend_string_init(quoted, quotedlen, 0);
-	efree(quoted);
 	return quoted_str;
 }
 
-static bool pdo_dblib_transaction_cmd(const char *cmd, pdo_dbh_t *dbh)
+static bool pdo_dblib_transaction_cmd(const char *qmd, pdo_dbh_t *dbh)
 {
 	pdo_dblib_db_handle *H = (pdo_dblib_db_handle *)dbh->driver_data;
 

ext/pdo_firebird/firebird_driver.c

@@ -653,7 +653,7 @@ static zend_string* firebird_handle_quoter(pdo_dbh_t *dbh, const zend_string *un
 {
 	int qcount = 0;
 	char const *co, *l, *r;
-	char *c, *quoted;
+	char *c;
 	size_t quotedlen;
 	zend_string *quoted_str;
 
@@ -666,7 +666,8 @@ static zend_string* firebird_handle_quoter(pdo_dbh_t *dbh, const zend_string *un
 	for (co = ZSTR_VAL(unquoted); (co = strchr(co,'\'')); qcount++, co++);
 
 	quotedlen = ZSTR_LEN(unquoted) + qcount + 2;
-	quoted = c = emalloc(quotedlen+1);
+	quoted_str = zend_string_alloc(quotedlen, 0);
+	c = ZSTR_VAL(quoted_str);
 	*c++ = '\'';
 
 	/* foreach (chunk that ends in a quote) */
@@ -678,12 +679,10 @@ static zend_string* firebird_handle_quoter(pdo_dbh_t *dbh, const zend_string *un
 	}
 
 	/* copy the remainder */
-	strncpy(c, l, quotedlen-(c-quoted)-1);
-	quoted[quotedlen-1] = '\'';
-	quoted[quotedlen]   = '\0';
+	strncpy(c, l, quotedlen-(c-ZSTR_VAL(quoted_str))-1);
+	ZSTR_VAL(quoted_str)[quotedlen-1] = '\'';
+	ZSTR_VAL(quoted_str)[quotedlen]   = '\0';
 
-	quoted_str = zend_string_init(quoted, quotedlen, 0);
-	efree(quoted);
 	return quoted_str;
 }
 /* }}} */