Skip to content

Commit 03a4ccd

Browse files
committed
use sha256 in openssl test suite
1 parent 6d96f39 commit 03a4ccd

15 files changed

+29
-63
lines changed

ext/openssl/tests/bug41033.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,11 @@ $pub = 'file://' . __DIR__ . '/' . 'bug41033pub.pem';
1010

1111
$prkeyid = openssl_get_privatekey($prv, "1234");
1212
$ct = "Hello I am some text!";
13-
openssl_sign($ct, $signature, $prkeyid, OPENSSL_ALGO_SHA1);
13+
openssl_sign($ct, $signature, $prkeyid, OPENSSL_ALGO_SHA256);
1414
echo "Signature: ".base64_encode($signature) . "\n";
1515

1616
$pukeyid = openssl_get_publickey($pub);
17-
$valid = openssl_verify($ct, $signature, $pukeyid, OPENSSL_ALGO_SHA1);
17+
$valid = openssl_verify($ct, $signature, $pukeyid, OPENSSL_ALGO_SHA256);
1818
echo "Signature validity: " . $valid . "\n";
1919

2020

ext/openssl/tests/bug61930.phpt

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,19 +4,20 @@ Bug #61930: openssl corrupts ssl key resource when using openssl_get_publickey()
44
openssl
55
--FILE--
66
<?php
7-
$cert = file_get_contents(__DIR__.'/cert.crt');
7+
$cert = file_get_contents(__DIR__.'/public.crt');
88

99
$data = <<<DATA
1010
Please verify me
1111
DATA;
1212

13-
$sig = 'f9Gyb6NV/ENn7GUa37ygTLcF93XHf5fbFTnoYF/O+fXbq3iChGUbET0RuhOsptl' .
14-
'AODi6JsDLnJO4ikcVZo0tC1fFTj3LyCuPy3ZdgJbbVxQ/rviROCmuMFTqUW/Xa2' .
15-
'LQYiapeCCgLQeWTLg7TM/BoHEkKbKLG/XT5jHvep1758A=';
13+
$sig = 'w45LtLoRY/WPk/kcmP6CwGysOMuxuLbD35xMB/iAe5IMiBJjz2D1WGEY7Vz+rLZmYqOo58qNC3VtTg6ge9+UhfQHplvs6cXGKm' .
14+
'SkQlYv4EeFoByqYfPU9k2dE/WEItOJUUyqu9pHaCmRtLpxoLnJcdQVdiXfT0t8KwxUzZYDjrSfhp7rbKhhCc4jZMwo9PvBuPAT' .
15+
'MEfZbRNaVpwCFpjmmJczZCHFZFm7JYzR2jU0sjJMGALXidNBs9p0Fi1TGz3pZkxnQ5lwI5DX5ZSY0jiOcoVFt7k29GVFd0DPjm' .
16+
'1NyieYU6tpnanG+ZqHIT8Um3FajYh0x1iMMe2lLETjklqYiw==';
1617

1718
$key = openssl_get_publickey($cert);
1819
var_dump(openssl_get_publickey($key));
19-
var_dump(openssl_verify($data, base64_decode($sig), $key));
20+
var_dump(openssl_verify($data, base64_decode($sig), $key, OPENSSL_ALGO_SHA256));
2021
?>
2122
--EXPECTF--
2223
object(OpenSSLAsymmetricKey)#%d (0) {

ext/openssl/tests/bug66501.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ AwEHoUQDQgAEPq4hbIWHvB51rdWr8ejrjWo4qVNWVugYFtPg/xLQw0mHkIPZ4DvK
1818
sqOTOnMoezkbSmVVMuwz9flvnqHGmQvmug==
1919
-----END EC PRIVATE KEY-----';
2020
$key = openssl_pkey_get_private($pkey);
21-
$res = openssl_sign($data ='alpha', $sign, $key, 'SHA1');
21+
$res = openssl_sign($data ='alpha', $sign, $key, 'SHA256');
2222
var_dump($res);
2323
?>
2424
--EXPECT--

ext/openssl/tests/ecc.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ $csr = openssl_csr_new($dn, $keyGenerate, $args);
6464

6565
var_dump($keyGenerate);
6666

67-
$args["digest_alg"] = "sha1";
67+
$args["digest_alg"] = "sha256";
6868
echo "Testing openssl_csr_new with existing ecc key\n";
6969
$csr = openssl_csr_new($dn, $key1, $args);
7070
var_dump($csr);

ext/openssl/tests/openssl.cnf

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@ tsa_policy2 = 1.2.3.4.5.6
77

88
[ req ]
99
default_bits = 1024
10+
default_md = sha256
1011
default_keyfile = privkey.pem
1112
distinguished_name = req_distinguished_name
1213
attributes = req_attributes

ext/openssl/tests/openssl_csr_export_basic.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ $dn = array(
1717
);
1818

1919
$args = array(
20-
"digest_alg" => "sha1",
20+
"digest_alg" => "sha256",
2121
"private_key_bits" => 2048,
2222
"private_key_type" => OPENSSL_KEYTYPE_DSA,
2323
"encrypt_key" => true,

ext/openssl/tests/openssl_csr_export_to_file_basic.phpt

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ $dn = array(
2525
);
2626

2727
$args = array(
28-
"digest_alg" => "sha1",
28+
"digest_alg" => "sha256",
2929
"private_key_bits" => 2048,
3030
"private_key_type" => OPENSSL_KEYTYPE_DSA,
3131
"encrypt_key" => true,
@@ -66,12 +66,12 @@ BggTncBh9ozkVQGS/P1m0zn/SKSgDO+6DdeLHLMjpUASaoYfsay4PJLAdnTqLOeM
6666
g6qNE6u0ebZXVfmpSmV1pSZ6kQnxbsb6rX1iOZxkwHnVWYb40Hy0EILo31x6BVqB
6767
m159m7s38ChiRHqlj20DmRfxXjiT5YDgYYQ29wQBTVQrTN5O9UW5Y+eKTXd8r6te
6868
dsbIBXdKN7NeX7ksGYHq1I3hLsP8EyvZO78qfjKyEB0Jj3UCAwEAAaAAMA0GCSqG
69-
SIb3DQEBBQUAA4IBAQCamzVmIbElkiDQKzQpkfU5tHjrWPrHDSB186NI0sQ8i6GQ
70-
1YT6yPAXBPTQ1aER/6uAZJL5HfWEX8V1rKbe8GkPAPCHHQzmHyWlaO2EHS57zJhk
71-
sRrhqkhhkSNiDg4OrsguhRtbB2VMGeDbqHGI89uGqqGHUiZc/Bh8N7WFXZkUU/A0
72-
sfBgVeqg0P4SWez5fHXqBNcjMdMI5f0bikcDZSIfTHS8FX+PMurLBC8UPB0YNIOl
73-
1r2Lvo+6YUHOziG1OwQd3K0xxu/JzzOE+lMB73ynz4V6DY5Qv3qVno1GpupvgmQA
74-
JViHkCA9x6m8RJXAFvqmgLlWlUzbDv/cRrDfjWjR
69+
SIb3DQEBCwUAA4IBAQCNtCIfMHBDRvNqHmrDfR/+A7ZJ+n/XzA2uQhvjEq91DeT8
70+
IE7gjUtmj2sqKmHGIDO4uN4F9ZHYzcNk23n6CMljYqJLbB2dHC0V6vkDB7qod1TH
71+
/SK39Yj0ji2AT45LD5rLH3vd1bjxdwwhyPyGhshKOIdnmBv4mwTRANIsiISMQV4Y
72+
ZPAXJ5DTKkgdsY14hqhyWct1bWMPpj2MCLQGjKxK8vmbiKaNL1XxAS7chTXoy7un
73+
NvBKc82Wy3XEuC9AkNFEytD6kA9gu8nFydvYTOvvhaQrf9RzwSitgi9Vj3mbujsN
74+
f1JMPX0/eHrKvG9wBZu28FdS54xoWGeD1NGraW24
7575
-----END CERTIFICATE REQUEST-----
7676
"
7777

ext/openssl/tests/openssl_csr_get_public_key_basic.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ $dn = array(
2323
);
2424

2525
$args = array(
26-
"digest_alg" => "sha1",
26+
"digest_alg" => "sha256",
2727
"private_key_bits" => 2048,
2828
"private_key_type" => OPENSSL_KEYTYPE_DSA,
2929
"encrypt_key" => true,

ext/openssl/tests/openssl_csr_get_subject_basic.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ $dn = array(
2323
);
2424

2525
$args = array(
26-
"digest_alg" => "sha1",
26+
"digest_alg" => "sha256",
2727
"private_key_bits" => 2048,
2828
"private_key_type" => OPENSSL_KEYTYPE_DSA,
2929
"encrypt_key" => true,

ext/openssl/tests/openssl_csr_sign_basic.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ $dn = array(
2020
);
2121

2222
$args = array(
23-
"digest_alg" => "sha1",
23+
"digest_alg" => "sha256",
2424
"private_key_bits" => 2048,
2525
"private_key_type" => OPENSSL_KEYTYPE_DSA,
2626
"encrypt_key" => true,

ext/openssl/tests/openssl_sign_basic.phpt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ $data = "Testing openssl_sign()";
88
$privkey = "file://" . __DIR__ . "/private_rsa_1024.key";
99
$wrong = "wrong";
1010

11-
var_dump(openssl_sign($data, $sign, $privkey)); // no output
11+
var_dump(openssl_sign($data, $sign, $privkey, OPENSSL_ALGO_SHA256)); // no output
1212
var_dump(openssl_sign($data, $sign, $wrong));
1313
?>
1414
--EXPECTF--

ext/openssl/tests/openssl_spki_export_challenge_basic.phpt

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ foreach ($key_sizes as $key_size) {
2222

2323
/* array of available hashings to test */
2424
$algo = array(
25-
OPENSSL_ALGO_MD5,
26-
OPENSSL_ALGO_SHA1,
2725
OPENSSL_ALGO_SHA224,
2826
OPENSSL_ALGO_SHA256,
2927
OPENSSL_ALGO_SHA384,
@@ -76,15 +74,3 @@ string\(36\) \"[0-9a-f]{8}\-([0-9a-f]{4}\-){3}[0-9a-f]{12}\"
7674
bool\(false\)
7775
string\(36\) \"[0-9a-f]{8}\-([0-9a-f]{4}\-){3}[0-9a-f]{12}\"
7876
bool\(false\)
79-
string\(36\) \"[0-9a-f]{8}\-([0-9a-f]{4}\-){3}[0-9a-f]{12}\"
80-
bool\(false\)
81-
string\(36\) \"[0-9a-f]{8}\-([0-9a-f]{4}\-){3}[0-9a-f]{12}\"
82-
bool\(false\)
83-
string\(36\) \"[0-9a-f]{8}\-([0-9a-f]{4}\-){3}[0-9a-f]{12}\"
84-
bool\(false\)
85-
string\(36\) \"[0-9a-f]{8}\-([0-9a-f]{4}\-){3}[0-9a-f]{12}\"
86-
bool\(false\)
87-
string\(36\) \"[0-9a-f]{8}\-([0-9a-f]{4}\-){3}[0-9a-f]{12}\"
88-
bool\(false\)
89-
string\(36\) \"[0-9a-f]{8}\-([0-9a-f]{4}\-){3}[0-9a-f]{12}\"
90-
bool\(false\)

ext/openssl/tests/openssl_spki_new_basic.phpt

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,6 @@ foreach ($key_sizes as $key_size) {
1616

1717
/* array of available hashings to test */
1818
$algo = array(
19-
OPENSSL_ALGO_MD5,
20-
OPENSSL_ALGO_SHA1,
2119
OPENSSL_ALGO_SHA224,
2220
OPENSSL_ALGO_SHA256,
2321
OPENSSL_ALGO_SHA384,
@@ -47,16 +45,10 @@ string(478) "%s"
4745
string(478) "%s"
4846
string(478) "%s"
4947
string(478) "%s"
50-
string(478) "%s"
51-
string(478) "%s"
52-
string(830) "%s"
5348
string(830) "%s"
5449
string(830) "%s"
5550
string(830) "%s"
5651
string(830) "%s"
57-
string(830) "%s"
58-
string(1510) "%s"
59-
string(1510) "%s"
6052
string(1510) "%s"
6153
string(1510) "%s"
6254
string(1510) "%s"

ext/openssl/tests/openssl_spki_verify_basic.phpt

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,6 @@ foreach ($key_sizes as $key_size) {
1818

1919
/* array of available hashings to test */
2020
$algo = array(
21-
OPENSSL_ALGO_SHA1,
22-
OPENSSL_ALGO_SHA224,
2321
OPENSSL_ALGO_SHA256,
2422
OPENSSL_ALGO_SHA384,
2523
OPENSSL_ALGO_SHA512,
@@ -65,15 +63,3 @@ bool(true)
6563
bool(false)
6664
bool(true)
6765
bool(false)
68-
bool(true)
69-
bool(false)
70-
bool(true)
71-
bool(false)
72-
bool(true)
73-
bool(false)
74-
bool(true)
75-
bool(false)
76-
bool(true)
77-
bool(false)
78-
bool(true)
79-
bool(false)

ext/openssl/tests/openssl_verify_basic.phpt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -9,12 +9,12 @@ $privkey = "file://" . __DIR__ . "/private_rsa_1024.key";
99
$pubkey = "file://" . __DIR__ . "/public.key";
1010
$wrong = "wrong";
1111

12-
openssl_sign($data, $sign, $privkey);
13-
var_dump(openssl_verify($data, $sign, $pubkey));
14-
var_dump(openssl_verify($data, $sign, $privkey));
15-
var_dump(openssl_verify($data, $sign, $wrong));
16-
var_dump(openssl_verify($data, $wrong, $pubkey));
17-
var_dump(openssl_verify($wrong, $sign, $pubkey));
12+
openssl_sign($data, $sign, $privkey, OPENSSL_ALGO_SHA256);
13+
var_dump(openssl_verify($data, $sign, $pubkey, OPENSSL_ALGO_SHA256));
14+
var_dump(openssl_verify($data, $sign, $privkey, OPENSSL_ALGO_SHA256));
15+
var_dump(openssl_verify($data, $sign, $wrong, OPENSSL_ALGO_SHA256));
16+
var_dump(openssl_verify($data, $wrong, $pubkey, OPENSSL_ALGO_SHA256));
17+
var_dump(openssl_verify($wrong, $sign, $pubkey, OPENSSL_ALGO_SHA256));
1818
?>
1919
--EXPECTF--
2020
int(1)

0 commit comments

Comments
 (0)