Remove always-false opcode check

nielsdos · nielsdos · commit 00b36ce44aa5 · 2024-07-02T02:51:18.000-07:00
opcode cannot be ZEND_POST_INC because of the if check above.
diff --git a/ext/opcache/jit/zend_jit_ir.c b/ext/opcache/jit/zend_jit_ir.c
@@ -4773,7 +4773,7 @@ static int zend_jit_inc_dec(zend_jit_ctx *jit, const zend_op *opline, uint32_t o
 		}
 		if ((opline->opcode == ZEND_PRE_INC || opline->opcode == ZEND_PRE_DEC) &&
 		    opline->result_type != IS_UNUSED) {
-			if (opline->opcode == ZEND_PRE_INC || opline->opcode == ZEND_POST_INC) {
+			if (opline->opcode == ZEND_PRE_INC) {
 				if (Z_MODE(res_addr) == IS_REG) {
 					jit_set_Z_DVAL(jit, res_addr, ir_CONST_DOUBLE((double)ZEND_LONG_MAX + 1.0));
 				} else {

Original file line number	Diff line number	Diff line change
`@@ -4773,7 +4773,7 @@ static int zend_jit_inc_dec(zend_jit_ctx jit, const zend_op opline, uint32_t o`
`4773`	`4773`	`}`
`4774`	`4774`	`if ((opline->opcode == ZEND_PRE_INC \|\| opline->opcode == ZEND_PRE_DEC) &&`
`4775`	`4775`	`opline->result_type != IS_UNUSED) {`
`4776`		`- if (opline->opcode == ZEND_PRE_INC \|\| opline->opcode == ZEND_POST_INC) {`
	`4776`	`+ if (opline->opcode == ZEND_PRE_INC) {`
`4777`	`4777`	`if (Z_MODE(res_addr) == IS_REG) {`
`4778`	`4778`	`jit_set_Z_DVAL(jit, res_addr, ir_CONST_DOUBLE((double)ZEND_LONG_MAX + 1.0));`
`4779`	`4779`	`} else {`