Skip to content

Commit 0057709

Browse files
committed
Fix [-Wundef] for CRC32 support
1 parent 5e1825a commit 0057709

File tree

4 files changed

+10
-10
lines changed

4 files changed

+10
-10
lines changed

ext/hash/hash_crc32.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ PHP_HASH_API void PHP_CRC32Update(PHP_CRC32_CTX *context, const unsigned char *i
2929
{
3030
size_t i = 0;
3131

32-
#if ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE || ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER
32+
#if defined(ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE) || defined(ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER)
3333
i += crc32_x86_simd_update(X86_CRC32, &context->state, input, len);
3434
#endif
3535

@@ -42,7 +42,7 @@ PHP_HASH_API void PHP_CRC32BUpdate(PHP_CRC32_CTX *context, const unsigned char *
4242
{
4343
size_t i = 0;
4444

45-
#if ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE || ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER
45+
#if defined(ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE) || defined(ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER)
4646
i += crc32_x86_simd_update(X86_CRC32B, &context->state, input, len);
4747
#endif
4848

@@ -55,7 +55,7 @@ PHP_HASH_API void PHP_CRC32CUpdate(PHP_CRC32_CTX *context, const unsigned char *
5555
{
5656
size_t i = 0;
5757

58-
#if ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE || ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER
58+
#if defined(ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE) || defined(ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER)
5959
i += crc32_x86_simd_update(X86_CRC32C, &context->state, input, len);
6060
#endif
6161

ext/standard/crc32.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,7 @@ PHP_FUNCTION(crc32)
9090
}
9191
#endif
9292

93-
#if ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE || ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER
93+
#if defined(ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE) || defined(ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER)
9494
size_t nr_simd = crc32_x86_simd_update(X86_CRC32B, &crc, (const unsigned char *)p, nr);
9595
nr -= nr_simd;
9696
p += nr_simd;

ext/standard/crc32_x86.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,16 +19,16 @@
1919

2020
#include "crc32_x86.h"
2121

22-
#if ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE || ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER
22+
#if defined(ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE) || defined(ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER)
2323
# include <nmmintrin.h>
2424
# include <wmmintrin.h>
2525
#endif
2626

27-
#if ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER
27+
#ifdef ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER
2828
# include "Zend/zend_cpuinfo.h"
2929
#endif
3030

31-
#if ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE || ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER
31+
#if defined(ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE) || defined(ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER)
3232

3333
typedef struct _crc32_pclmul_bit_consts {
3434
uint64_t k1k2[2];
@@ -287,7 +287,7 @@ size_t crc32_pclmul_reflected_batch(uint32_t *crc, const unsigned char *p, size_
287287
return (nr_in - nr); /* the nr processed */
288288
}
289289

290-
# if ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE
290+
# ifdef ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE
291291
size_t crc32_x86_simd_update(X86_CRC32_TYPE type, uint32_t *crc, const unsigned char *p, size_t nr)
292292
# else /* ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER */
293293
size_t crc32_sse42_pclmul_update(X86_CRC32_TYPE type, uint32_t *crc, const unsigned char *p, size_t nr)

ext/standard/crc32_x86.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@ typedef enum {
3535
X86_CRC32_MAX,
3636
} X86_CRC32_TYPE;
3737

38-
#if ZEND_INTRIN_SSE4_2_PCLMUL_FUNC_PTR
38+
#ifdef ZEND_INTRIN_SSE4_2_PCLMUL_FUNC_PTR
3939
PHP_MINIT_FUNCTION(crc32_x86_intrin);
4040
#endif
4141

42-
#if ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE || ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER
42+
#if defined(ZEND_INTRIN_SSE4_2_PCLMUL_NATIVE) || defined(ZEND_INTRIN_SSE4_2_PCLMUL_RESOLVER)
4343
/* Return the size processed by SIMD routine */
4444
size_t crc32_x86_simd_update(X86_CRC32_TYPE type, uint32_t *crc, const unsigned char *p, size_t nr);
4545
#else

0 commit comments

Comments
 (0)