Merge pull request #21 from johnbillion/phpstan-param-arrays

Author: szepeviktor

.travis.yml

@@ -48,3 +48,5 @@ script:
   - "git diff --exit-code"
   # Execute stubs
   - "php -f wordpress-stubs.php"
+  # Analyse our code
+  - "vendor/bin/phpstan"

composer.json

@@ -13,7 +13,9 @@
     },
     "require-dev": {
         "php": "~7.3 || ~8.0",
-        "php-stubs/generator": "^0.7.0",
+        "phpdocumentor/reflection-docblock": "^5.3",
+        "php-stubs/generator": "^0.8.0",
+        "phpstan/phpstan": "^1.2",
         "nikic/php-parser": "< 4.12.0"
     },
     "suggest": {

generate.sh

@@ -18,6 +18,7 @@ fi
 "$(dirname "$0")/vendor/bin/generate-stubs" \
     --force \
     --finder=finder.php \
+    --visitor=visitor.php \
     --header="$HEADER" \
     --functions \
     --classes \

phpstan.neon

@@ -0,0 +1,4 @@
+parameters:
+    level: 8
+    paths:
+        - visitor.php

visitor.php

@@ -0,0 +1,242 @@
+<?php
+
+declare(strict_types = 1);
+
+use phpDocumentor\Reflection\DocBlock\Description;
+use phpDocumentor\Reflection\DocBlock\Tags\Param;
+use phpDocumentor\Reflection\DocBlock\Tags\Return_;
+use phpDocumentor\Reflection\Type;
+use PhpParser\Comment\Doc;
+use PhpParser\Node;
+use PhpParser\Node\Stmt\ClassMethod;
+use PhpParser\Node\Stmt\Function_;
+use StubsGenerator\NodeVisitor;
+
+return new class extends NodeVisitor {
+
+    /**
+     * @var \phpDocumentor\Reflection\DocBlockFactory
+     */
+    private $docBlockFactory;
+
+    public function __construct()
+    {
+        $this->docBlockFactory = \phpDocumentor\Reflection\DocBlockFactory::createInstance();
+    }
+
+    public function enterNode(Node $node)
+    {
+        parent::enterNode($node);
+
+        if (!($node instanceof Function_) && !($node instanceof ClassMethod)) {
+            return null;
+        }
+
+        $docComment = $node->getDocComment();
+
+        if (!($docComment instanceof Doc)) {
+            return null;
+        }
+
+        $newDocComment = $this->addArrayHashNotation($docComment);
+
+        if ($newDocComment !== null) {
+            $node->setDocComment($newDocComment);
+        }
+
+        return null;
+    }
+
+    private function addArrayHashNotation(Doc $docComment): ?Doc
+    {
+        $docCommentText = $docComment->getText();
+
+        try {
+            $docblock = $this->docBlockFactory->create($docCommentText);
+        } catch ( \RuntimeException $e ) {
+            return null;
+        } catch ( \InvalidArgumentException $e ) {
+            return null;
+        }
+
+        /** @var \phpDocumentor\Reflection\DocBlock\Tags\Param[] */
+        $params = $docblock->getTagsByName('param');
+
+        /** @var \phpDocumentor\Reflection\DocBlock\Tags\Return_[] */
+        $returns = $docblock->getTagsByName('return');
+
+        if (!$params && !$returns) {
+            return null;
+        }
+
+        $additions = [];
+
+        foreach ($params as $param) {
+            $addition = $this->getAdditionFromParam($param);
+
+            if ($addition !== null) {
+                $additions[] = $addition;
+            }
+        }
+
+        if ($returns) {
+            $addition = $this->getAdditionFromReturn($returns[0]);
+
+            if ($addition !== null) {
+                $additions[] = $addition;
+            }
+        }
+
+        if (!$additions) {
+            return null;
+        }
+
+        $newDocComment = sprintf(
+            "%s\n%s\n */",
+            substr($docCommentText, 0, -4),
+            implode("\n", $additions)
+        );
+
+        return new Doc($newDocComment, $docComment->getLine(), $docComment->getFilePos());
+    }
+
+    private function getAdditionFromParam(Param $tag): ?string
+    {
+        $tagDescription = $tag->getDescription();
+        $tagVariableName = $tag->getVariableName();
+        $tagVariableType = $tag->getType();
+
+        // Skip if information we need is missing.
+        if (!$tagDescription || !$tagVariableName || !$tagVariableType) {
+            return null;
+        }
+
+        $elements = $this->getElementsFromDescription($tagDescription, true);
+
+        if ($elements === null) {
+            return null;
+        }
+
+        $tagVariableType = $this->getTypeNameFromType($tagVariableType);
+
+        if ($tagVariableType === null) {
+            return null;
+        }
+
+        // It's common for an args parameter to accept a query var string or array with `string|array`.
+        // Remove the accepted string type for these so we get the strongest typing we can manage.
+        $tagVariableType = str_replace(['|string', 'string|'], '', $tagVariableType);
+
+        return sprintf(
+            " * @phpstan-param %1\$s{\n *   %2\$s,\n * } $%3\$s",
+            $tagVariableType,
+            implode(",\n *   ", $elements),
+            $tagVariableName
+        );
+    }
+
+    private function getAdditionFromReturn(Return_ $tag): ?string
+    {
+        $tagDescription = $tag->getDescription();
+        $tagVariableType = $tag->getType();
+
+        // Skip if information we need is missing.
+        if (!$tagDescription || !$tagVariableType) {
+            return null;
+        }
+
+        $elements = $this->getElementsFromDescription($tagDescription, false);
+
+        if ($elements === null) {
+            return null;
+        }
+
+        $tagVariableType = $this->getTypeNameFromType($tagVariableType);
+
+        if ($tagVariableType === null) {
+            return null;
+        }
+
+        return sprintf(
+            " * @phpstan-return %1\$s{\n *   %2\$s,\n * }",
+            $tagVariableType,
+            implode(",\n *   ", $elements)
+        );
+    }
+
+    private function getTypeNameFromType(Type $tagVariableType): ?string
+    {
+        // PHPStan dosn't support typed array shapes (`int[]{...}`) so replace
+        // typed arrays such as `int[]` with `array`.
+        $tagVariableType = preg_replace('#[a-zA-Z0-9_]+\[\]#', 'array', $tagVariableType->__toString());
+
+        if ($tagVariableType === null) {
+            return null;
+        }
+
+        if (strpos($tagVariableType, 'array') === false) {
+            // Skip if we have hash notation that's not for an array (ie. for `object`).
+            return null;
+        }
+
+        if (strpos($tagVariableType, 'array|') !== false) {
+            // Move `array` to the end of union types so the appended array shape works.
+            $tagVariableType = str_replace('array|', '', $tagVariableType) . '|array';
+        }
+
+        return $tagVariableType;
+    }
+
+    /**
+     * @return ?string[]
+     */
+    private function getElementsFromDescription(Description $tagDescription, bool $optional): ?array
+    {
+        $text = $tagDescription->__toString();
+
+        // Skip if the description doesn't contain at least one correctly
+        // formatted `@type`, which indicates an array hash.
+        if (strpos($text, '    @type ') === false) {
+            return null;
+        }
+
+        // Populate `$types` with the value of each top level `@type`.
+        $types = preg_split('/\R+    @type /', $text);
+
+        if ($types === false) {
+            return null;
+        }
+
+        unset($types[0]);
+        $elements = [];
+
+        foreach ($types as $typeTag) {
+            $parts = preg_split('#\s+#', trim($typeTag));
+
+            if ($parts === false || count($parts) < 2) {
+                return null;
+            }
+
+            list($type, $name) = $parts;
+
+            // Bail out completely if any element doesn't have a static key.
+            if (strpos($name, '...$') !== false) {
+                return null;
+            }
+
+            // Bail out completely if the name of any element is invalid.
+            if (strpos($name, '$') !== 0) {
+                return null;
+            }
+
+            $elements[] = sprintf(
+                '%1$s%2$s: %3$s',
+                substr($name, 1),
+                $optional ? '?' : '',
+                $type
+            );
+        }
+
+        return $elements;
+    }
+};