Fixed wrong cookie header generation.

marcj · marcj · commit 3d37c25ea1c9 · 2016-04-11T00:52:19.000+02:00
Cookies with path or expires didn't work with Safari, which is more strict with handling set-cookie header than chrome.
diff --git a/Bridges/HttpKernel.php b/Bridges/HttpKernel.php
@@ -203,14 +203,14 @@ protected function mapResponse(HttpResponse $reactResponse, SymfonyResponse $syR
             $cookieHeader = sprintf('%s=%s', $cookie->getName(), $cookie->getValue());
 
             if ($cookie->getPath()) {
-                $cookieHeader .= '; Path=' . urlencode($cookie->getPath());
+                $cookieHeader .= '; Path=' . $cookie->getPath();
             }
             if ($cookie->getDomain()) {
                 $cookieHeader .= '; Domain=' . $cookie->getDomain();
             }
 
             if ($cookie->getExpiresTime()) {
-                $cookieHeader .= '; Expires=' . $cookie->getExpiresTime();
+                $cookieHeader .= '; Expires=' . gmdate('D, d-M-Y H:i:s', $cookie->getExpiresTime()). ' GMT';
             }
 
             if ($cookie->isSecure()) {

Original file line number	Diff line number	Diff line change
`@@ -203,14 +203,14 @@ protected function mapResponse(HttpResponse $reactResponse, SymfonyResponse $syR`
`203`	`203`	`$cookieHeader = sprintf('%s=%s', $cookie->getName(), $cookie->getValue());`
`204`	`204`
`205`	`205`	`if ($cookie->getPath()) {`
`206`		`- $cookieHeader .= '; Path=' . urlencode($cookie->getPath());`
	`206`	`+ $cookieHeader .= '; Path=' . $cookie->getPath();`
`207`	`207`	`}`
`208`	`208`	`if ($cookie->getDomain()) {`
`209`	`209`	`$cookieHeader .= '; Domain=' . $cookie->getDomain();`
`210`	`210`	`}`
`211`	`211`
`212`	`212`	`if ($cookie->getExpiresTime()) {`
`213`		`- $cookieHeader .= '; Expires=' . $cookie->getExpiresTime();`
	`213`	`+ $cookieHeader .= '; Expires=' . gmdate('D, d-M-Y H:i:s', $cookie->getExpiresTime()). ' GMT';`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`if ($cookie->isSecure()) {`