Skip to content

Commit 4e3e88c

Browse files
committed
GH Actions workflows: fix PHP set up step
To disable code coverage, the `coverage` key should be set to `none`. `false` is not a valid (or supported) value, so the behaviour may be unpredictable. Ref: https://github.com/shivammathur/setup-php#disable-coverage
1 parent 11a5bdd commit 4e3e88c

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

.github/workflows/release.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ jobs:
1919
with:
2020
php-version: 5.4
2121
extensions: exif, phar, openssl
22-
coverage: false
22+
coverage: none
2323
ini-values: phar.readonly=Off
2424

2525
- name: Install Box from GitHub
@@ -79,7 +79,7 @@ jobs:
7979
uses: shivammathur/setup-php@v2
8080
with:
8181
php-version: ${{ matrix.php }}
82-
coverage: false
82+
coverage: none
8383

8484
- name: Run linter against codebase
8585
run: php ./parallel-lint.phar src/

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ jobs:
6161
with:
6262
php-version: 5.4
6363
extensions: exif, phar, openssl
64-
coverage: false
64+
coverage: none
6565
ini-values: phar.readonly=Off
6666

6767
- name: Install Box from GitHub
@@ -121,7 +121,7 @@ jobs:
121121
uses: shivammathur/setup-php@v2
122122
with:
123123
php-version: ${{ matrix.php }}
124-
coverage: false
124+
coverage: none
125125

126126
- name: Run linter against codebase
127127
run: php ./parallel-lint.phar src/

0 commit comments

Comments
 (0)