Skip to content

Commit 023b7bf

Browse files
jrfnlgrogy
authored andcommitted
GH Actions: add ini settings to "release" workflow
Follow-up on PR 65, which turned set `error_reporting` to `E_ALL` and turned `display_errors` on in the Test workflow. Only just now noticed that I missed doing the same in the Release workflow. This also changes the setting for `error_reporting` to `-1` as `E_ALL` does not contain **all** errors across PHP versions, while `-1` will show them, independently of the PHP version. Also turning on assertions, just in case they are used under the hood in the test framework.
1 parent 62df02c commit 023b7bf

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/release.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ jobs:
2222
php-version: 8.0
2323
extensions: exif, phar, openssl
2424
coverage: none
25-
ini-values: phar.readonly=Off
25+
ini-values: phar.readonly=Off, error_reporting=-1, display_errors=On, zend.assertions=1
2626

2727
- name: Install Composer dependencies
2828
uses: ramsey/composer-install@v1
@@ -84,6 +84,7 @@ jobs:
8484
uses: shivammathur/setup-php@v2
8585
with:
8686
php-version: ${{ matrix.php }}
87+
ini-values: error_reporting=-1, display_errors=On, zend.assertions=1
8788
coverage: none
8889

8990
- name: Run linter against codebase

.github/workflows/test.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ jobs:
4848
php-version: 8.0
4949
extensions: exif, phar, openssl
5050
coverage: none
51-
ini-values: phar.readonly=Off, error_reporting=E_ALL, display_errors=On
51+
ini-values: phar.readonly=Off, error_reporting=-1, display_errors=On, zend.assertions=1
5252

5353
- name: Install Composer dependencies
5454
uses: ramsey/composer-install@v1
@@ -107,7 +107,7 @@ jobs:
107107
uses: shivammathur/setup-php@v2
108108
with:
109109
php-version: ${{ matrix.php }}
110-
ini-values: error_reporting=E_ALL, display_errors=On
110+
ini-values: error_reporting=-1, display_errors=On, zend.assertions=1
111111
coverage: none
112112

113113
# Remove PHPCS as it has a minimum PHP requirements of PHP 5.4 and would block install on PHP 5.3.

0 commit comments

Comments
 (0)