Skip to content

Commit e73d9a0

Browse files
committed
Cleanup
1 parent 7897d0d commit e73d9a0

File tree

2 files changed

+0
-3
lines changed

2 files changed

+0
-3
lines changed

src/lib/ColumnToCode.php

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -345,9 +345,7 @@ private function resolve():void
345345
$fluentSize = $this->column->size ? '(' . $this->column->size . ')' : '()';
346346
$rawSize = $this->column->size ? '(' . $this->column->size . ')' : '';
347347
$this->rawParts['nullable'] = $this->column->allowNull ? 'NULL' : 'NOT NULL';
348-
// if (!ApiGenerator::isPostgres()) {
349348
$this->fluentParts['nullable'] = $this->column->allowNull === true ? 'null()' : 'notNull()';
350-
// }
351349
if (array_key_exists($dbType, self::INT_TYPE_MAP)) {
352350
$this->fluentParts['type'] = self::INT_TYPE_MAP[$dbType] . $fluentSize;
353351
$this->rawParts['type'] =

src/lib/migrations/PostgresMigrationBuilder.php

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,6 @@ protected function buildColumnChanges(ColumnSchema $current, ColumnSchema $desir
7676
if (in_array('allowNull', $changed, true)
7777
&& ($forUp === false || $forDown === false)
7878
) {
79-
// TODO if last up code contains `null()` string then do execute below statement, same for notNull() and same in down code
8079
if ($desired->allowNull === true) {
8180
$this->migration->addUpCode($this->recordBuilder->dropColumnNotNull($tableName, $desired));
8281
$this->migration->addDownCode($this->recordBuilder->setColumnNotNull($tableName, $current), true);

0 commit comments

Comments
 (0)