Clean up event loop from client

Author: WyriHaximus

src/Client.php

@@ -23,26 +23,13 @@ class Client implements HttpClient, HttpAsyncClient
      */
     private $client;
 
-    /**
-     * React event loop.
-     *
-     * @var LoopInterface
-     */
-    private $loop;
-
     /**
      * Initialize the React client.
      */
     public function __construct(
-        LoopInterface $loop = null,
         ReactBrowser $client = null
     ) {
-        if (null !== $client && null === $loop) {
-            throw new \RuntimeException('You must give a LoopInterface instance with the Client');
-        }
-
-        $this->loop = $loop ?: ReactFactory::buildEventLoop();
-        $this->client = $client ?: ReactFactory::buildHttpClient($this->loop);
+        $this->client = $client ?: ReactFactory::buildHttpClient();
     }
 
     /**

src/ReactFactory.php

@@ -14,25 +14,16 @@
  */
 class ReactFactory
 {
-    /**
-     * Build a react Event Loop.
-     */
-    public static function buildEventLoop(): LoopInterface
-    {
-        return Loop::get();
-    }
-
     /**
      * Build a React Http Client.
      *
      * @param ConnectorInterface|null $connector only pass this argument if you need to customize DNS
      *                                           behaviour
      */
     public static function buildHttpClient(
-        LoopInterface $loop,
         ConnectorInterface $connector = null
     ): Browser {
-        return (new Browser($loop, $connector))
+        return (new Browser($connector))
             ->withRejectErrorResponse(false)
             ->withFollowRedirects(false);
     }

tests/ReactFactoryTest.php

@@ -16,27 +16,17 @@
  */
 class ReactFactoryTest extends TestCase
 {
-    /**
-     * @var \React\EventLoop\LoopInterface
-     */
-    private $loop;
-
-    protected function setUp(): void
-    {
-        $this->loop = $this->getMockBuilder(LoopInterface::class)->getMock();
-    }
-
     public function testBuildHttpClientWithConnector()
     {
         /** @var ConnectorInterface $connector */
         $connector = $this->getMockBuilder(ConnectorInterface::class)->getMock();
-        $client = ReactFactory::buildHttpClient($this->loop, $connector);
+        $client = ReactFactory::buildHttpClient($connector);
         $this->assertInstanceOf(Browser::class, $client);
     }
 
     public function testBuildHttpClientWithoutConnector()
     {
-        $client = ReactFactory::buildHttpClient($this->loop);
+        $client = ReactFactory::buildHttpClient();
         $this->assertInstanceOf(Browser::class, $client);
     }
 }