fix static analysis

Author: dbu

.gitattributes

@@ -1,15 +1,8 @@
-.editorconfig     export-ignore
-.gitattributes    export-ignore
-/.github/         export-ignore
-.gitignore        export-ignore
-/.php_cs          export-ignore
-/.scrutinizer.yml export-ignore
-/.styleci.yml     export-ignore
-/.travis.yml      export-ignore
-/behat.yml.dist   export-ignore
-/features/        export-ignore
-/phpspec.ci.yml   export-ignore
-/phpspec.yml.dist export-ignore
-/phpunit.xml.dist export-ignore
-/spec/            export-ignore
-/tests/           export-ignore
+.editorconfig           export-ignore
+.gitattributes          export-ignore
+/.github/               export-ignore
+.gitignore              export-ignore
+/.php-cs-fixer.dist.php export-ignore
+/phpstan.neon.dist      export-ignore
+/phpunit.xml.dist       export-ignore
+/tests/                 export-ignore

.github/workflows/static.yml

@@ -33,4 +33,4 @@ jobs:
       - name: PHP-CS-Fixer
         uses: docker://oskarstark/php-cs-fixer-ga
         with:
-          args: --dry-run --diff-format udiff
+          args: --dry-run --diff

.gitignore

@@ -1,7 +1,6 @@
-/behat.yml
 /build/
 /composer.lock
-/phpspec.yml
 /phpunit.xml
 /vendor/
+.php-cs-fixer.php
 .phpunit.result.cache

.php-cs-fixer.dist.php

@@ -0,0 +1,16 @@
+<?php
+
+$finder = PhpCsFixer\Finder::create()
+    ->exclude('vendor')
+    ->in(__DIR__)
+;
+
+$config = (new PhpCsFixer\Config())
+    ->setRiskyAllowed(true)
+    ->setRules([
+        '@Symfony' => true,
+    ])
+    ->setFinder($finder)
+;
+
+return $config;

.php_cs.dist

@@ -2,3 +2,6 @@ parameters:
     level: max
     paths:
         - src
+    ignoreErrors:
+        - message: '#^Method Http\\Adapter\\React\\Client::sendRequest\(\) should return Psr\\Http\\Message\\ResponseInterface but returns mixed.$#'
+          path: src/Client.php

phpstan.neon.dist

@@ -52,6 +52,8 @@ public function sendRequest(RequestInterface $request): ResponseInterface
     {
         $promise = $this->sendAsyncRequest($request);
 
+        // The promise is declared to return mixed, but the react client promise returns a response.
+        // We unwrap the exception if there is any, otherwise the promise would return null on error.
         return $promise->wait();
     }
 

src/Client.php

@@ -71,11 +71,11 @@ public function exceptionThatIsThrownFromReactProvider()
         $response = $this->getMockBuilder(ResponseInterface::class)->getMock();
 
         return [
-            'string'                   => [$request, 'whatever', UnexpectedValueException::class],
+            'string' => [$request, 'whatever', UnexpectedValueException::class],
             'InvalidArgumentException' => [$request, new InvalidArgumentException('Something went wrong'), TransferException::class],
-            'RuntimeException'         => [$request, new RuntimeException('Something happened inside ReactPHP engine'), NetworkException::class],
-            'NetworkException'         => [$request, new NetworkException('Something happened inside ReactPHP engine', $request), NetworkException::class],
-            'HttpException'            => [$request, new HttpException('Something happened inside ReactPHP engine', $request, $response), HttpException::class],
+            'RuntimeException' => [$request, new RuntimeException('Something happened inside ReactPHP engine'), NetworkException::class],
+            'NetworkException' => [$request, new NetworkException('Something happened inside ReactPHP engine', $request), NetworkException::class],
+            'HttpException' => [$request, new HttpException('Something happened inside ReactPHP engine', $request, $response), HttpException::class],
         ];
     }
 }