From 8d1993c9e1328e7f35a079f5db23c809835706bc Mon Sep 17 00:00:00 2001 From: David Buchmann Date: Fri, 28 Apr 2023 16:05:42 +0200 Subject: [PATCH] split out legacy tests --- .github/PULL_REQUEST_TEMPLATE.md | 2 +- .github/workflows/laminas-legacy.yml | 19 +++++++++++++++++++ .github/workflows/laminas.yml | 2 +- README.md | 6 +++--- 4 files changed, 24 insertions(+), 5 deletions(-) create mode 100644 .github/workflows/laminas-legacy.yml diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 0c437b7..904772f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -44,4 +44,4 @@ $foo->doSomething(); #### Note -The CI runs the integration tests with all implementations. It is normal that not all tests succeed. When adding test cases, please check the output if the new test fails and if so report it to the affected implementations. +The CI runs the integration tests with all implementations. It is expected that not all tests succeed and does not prevent merging a pull request. When adding test cases, please check the output if the new test fails and if so report it to the affected implementations. diff --git a/.github/workflows/laminas-legacy.yml b/.github/workflows/laminas-legacy.yml new file mode 100644 index 0000000..04f3686 --- /dev/null +++ b/.github/workflows/laminas-legacy.yml @@ -0,0 +1,19 @@ +name: Laminas Legacy + +on: + push: + branches: + - master + pull_request: + +jobs: + latest: + strategy: + fail-fast: false + matrix: + php: [ '7.2', '7.3', '7.4' ] + uses: ./.github/workflows/integration.yml + with: + php: ${{ matrix.php }} + suite: Laminas + package: laminas/laminas-diactoros diff --git a/.github/workflows/laminas.yml b/.github/workflows/laminas.yml index 3ba0214..66a42e9 100644 --- a/.github/workflows/laminas.yml +++ b/.github/workflows/laminas.yml @@ -11,7 +11,7 @@ jobs: strategy: fail-fast: false matrix: - php: [ '7.2', '7.3', '7.4', '8.0', '8.1', '8.2' ] + php: [ '8.0', '8.1', '8.2' ] uses: ./.github/workflows/integration.yml with: php: ${{ matrix.php }} diff --git a/README.md b/README.md index e9a8173..67e9894 100644 --- a/README.md +++ b/README.md @@ -6,10 +6,10 @@ ## Status -| PSR7 Implementation | Status | -| ------------------- |:-------------:| +| PSR7 Implementation | Status | Legacy | +| ------------------- |:-------------:|:------:| | Guzzle | [![Guzzle](https://github.com/php-http/psr7-integration-tests/actions/workflows/guzzle.yml/badge.svg)](https://github.com/php-http/psr7-integration-tests/actions/workflows/guzzle.yml) | -| Laminas | [![Laminas](https://github.com/php-http/psr7-integration-tests/actions/workflows/laminas.yml/badge.svg)](https://github.com/php-http/psr7-integration-tests/actions/workflows/laminas.yml) | +| Laminas | [![Laminas](https://github.com/php-http/psr7-integration-tests/actions/workflows/laminas.yml/badge.svg)](https://github.com/php-http/psr7-integration-tests/actions/workflows/laminas.yml) | [Legacy](https://github.com/php-http/psr7-integration-tests/actions/workflows/laminas-legacy.yml) (failures expected) | | Slim | [![Slim](https://github.com/php-http/psr7-integration-tests/actions/workflows/slim.yml/badge.svg)](https://github.com/php-http/psr7-integration-tests/actions/workflows/slim.yml) | | Nyholm | [![Nyholm](https://github.com/php-http/psr7-integration-tests/actions/workflows/nyholm.yml/badge.svg)](https://github.com/php-http/psr7-integration-tests/actions/workflows/nyholm.yml) | | RingCentral | [![RingCentral](https://github.com/php-http/psr7-integration-tests/actions/workflows/ringcentral.yml/badge.svg)](https://github.com/php-http/psr7-integration-tests/actions/workflows/ringcentral.yml) |