Adds Cookie::createWithoutValidation and Cookie::isValid

Adds a named constructor to avoid cookie attributes validation during
instantination, and a method to check if cookie attributes are valid.

Author: ajgarlag

CHANGELOG.md

@@ -3,14 +3,20 @@
 
 ## Unreleased
 
-## Fixed
+### Added
+
+ - Cookie::createWithoutValidation Static constructor to create a cookie. Will not perform any attribute validation during instantiation.
+ - Cookie::isValid Method to check if cookie attributes are valid.
+
+### Fixed
 
  - FilteredStream::getSize returns null because the contents size is unknown.
 
 ### Deprecated
 
  - FilteredStream::getReadFilter The read filter is internal and should never be used by consuming code.
  - FilteredStream::getWriteFilter We did not implement writing to the streams at all. And if we do, the filter is an internal information and should not be used by consuming code.
+ - Attributes validation during Cookie instantiation is deprecated and will be removed in 2.0. Use the new `Cookie::isValid` to check if attributes are valid.
 
 
 ## 1.4.1 - 2016-12-16

src/Cookie.php

@@ -53,6 +53,13 @@ final class Cookie
      */
     private $expires;
 
+    /**
+     * Validation state.
+     *
+     * @var bool
+     */
+    private $valid;
+
     /**
      * @param string         $name
      * @param string|null    $value
@@ -61,9 +68,10 @@ final class Cookie
      * @param string|null    $path
      * @param bool           $secure
      * @param bool           $httpOnly
-     * @param \DateTime|null $expires  Expires attribute is HTTP 1.0 only and should be avoided.
+     * @param \DateTime|null $expires           Expires attribute is HTTP 1.0 only and should be avoided.
+     * @param bool           $requireValidation deprecated since version 1.5. Will be removed in 2.0
      *
-     * @throws \InvalidArgumentException If name, value or max age is not valid.
+     * @throws \InvalidArgumentException If name, value or max age is not valid. Attributes validation during instantiation is deprecated since 1.5 and will be removed in 2.0.
      */
     public function __construct(
         $name,
@@ -73,11 +81,16 @@ public function __construct(
         $path = null,
         $secure = false,
         $httpOnly = false,
-        \DateTime $expires = null
+        \DateTime $expires = null,
+        $requireValidation = true
     ) {
-        $this->validateName($name);
-        $this->validateValue($value);
-        $this->validateMaxAge($maxAge);
+        if ($requireValidation) {
+            @trigger_error('Attributes validation during instantiation is deprecated since 1.5 and will be removed in 2.0', E_USER_DEPRECATED);
+            $this->validateName($name);
+            $this->validateValue($value);
+            $this->validateMaxAge($maxAge);
+            $this->valid = true;
+        }
 
         $this->name = $name;
         $this->value = $value;
@@ -89,6 +102,19 @@ public function __construct(
         $this->httpOnly = (bool) $httpOnly;
     }
 
+    public function createWithoutValidation(
+        $name,
+        $value = null,
+        $maxAge = null,
+        $domain = null,
+        $path = null,
+        $secure = false,
+        $httpOnly = false,
+        \DateTime $expires = null
+    ) {
+        return new self($name, $value, $maxAge, $domain, $path, $secure, $httpOnly, $expires, false);
+    }
+
     /**
      * Returns the name.
      *
@@ -380,6 +406,27 @@ public function match(Cookie $cookie)
         return $this->name === $cookie->name && $this->domain === $cookie->domain and $this->path === $cookie->path;
     }
 
+    /**
+     * Validates cookie attributes.
+     *
+     * @return bool
+     */
+    public function isValid()
+    {
+        if (null === $this->valid) {
+            try {
+                $this->validateName($this->name);
+                $this->validateValue($this->value);
+                $this->validateMaxAge($this->maxAge);
+                $this->valid = true;
+            } catch (\InvalidArgumentException $e) {
+                $this->valid = false;
+            }
+        }
+
+        return $this->valid;
+    }
+
     /**
      * Validates the name attribute.
      *