Add exception to zlib dependant streams when zlib is not enabled

Add stream behavior

Improve zlib tests

Remove php-mock dependency

Add zlib extension check to InflateStream

Author: sagikazarmark

spec/Encoding/ChunkStreamSpec.php

@@ -8,6 +8,8 @@
 
 class ChunkStreamSpec extends ObjectBehavior
 {
+    use StreamBehavior;
+
     function let(StreamInterface $stream)
     {
         if (defined('HHVM_VERSION')) {
@@ -22,11 +24,6 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Message\Encoding\ChunkStream');
     }
 
-    function it_is_a_stream()
-    {
-        $this->shouldImplement('Psr\Http\Message\StreamInterface');
-    }
-
     function it_chunks_content()
     {
         $stream = new MemoryStream('This is a stream');

spec/Encoding/CompressStreamSpec.php

@@ -8,6 +8,8 @@
 
 class CompressStreamSpec extends ObjectBehavior
 {
+    use StreamBehavior, ZlibStreamBehavior;
+
     function let(StreamInterface $stream)
     {
         if (defined('HHVM_VERSION')) {
@@ -22,11 +24,6 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Message\Encoding\CompressStream');
     }
 
-    function it_is_a_stream()
-    {
-        $this->shouldImplement('Psr\Http\Message\StreamInterface');
-    }
-
     function it_reads()
     {
         $stream = new MemoryStream('This is a test stream');

spec/Encoding/DechunkStreamSpec.php

@@ -8,6 +8,8 @@
 
 class DechunkStreamSpec extends ObjectBehavior
 {
+    use StreamBehavior;
+
     function let(StreamInterface $stream)
     {
         if (defined('HHVM_VERSION')) {
@@ -22,11 +24,6 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Message\Encoding\DechunkStream');
     }
 
-    function it_is_a_stream()
-    {
-        $this->shouldImplement('Psr\Http\Message\StreamInterface');
-    }
-
     function it_reads()
     {
         $stream = new MemoryStream("4\r\ntest\r\n4\r\ntest\r\n0\r\n\r\n\0");

spec/Encoding/DecompressStreamSpec.php

@@ -8,6 +8,8 @@
 
 class DecompressStreamSpec extends ObjectBehavior
 {
+    use StreamBehavior, ZlibStreamBehavior;
+
     function let(StreamInterface $stream)
     {
         if (defined('HHVM_VERSION')) {
@@ -22,11 +24,6 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Message\Encoding\DecompressStream');
     }
 
-    function it_is_a_stream()
-    {
-        $this->shouldImplement('Psr\Http\Message\StreamInterface');
-    }
-
     function it_reads()
     {
         // "This is a test stream" | deflate

spec/Encoding/DeflateStreamSpec.php

@@ -7,6 +7,8 @@
 
 class DeflateStreamSpec extends ObjectBehavior
 {
+    use StreamBehavior;
+
     function let(StreamInterface $stream)
     {
         $this->beConstructedWith($stream);
@@ -17,11 +19,6 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Message\Encoding\DeflateStream');
     }
 
-    function it_is_a_stream()
-    {
-        $this->shouldImplement('Psr\Http\Message\StreamInterface');
-    }
-
     function it_reads()
     {
         $stream = new MemoryStream('This is a test stream');

spec/Encoding/GzipDecodeStreamSpec.php

@@ -8,6 +8,8 @@
 
 class GzipDecodeStreamSpec extends ObjectBehavior
 {
+    use StreamBehavior, ZlibStreamBehavior;
+
     function let(StreamInterface $stream)
     {
         if (defined('HHVM_VERSION')) {
@@ -22,11 +24,6 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Message\Encoding\GzipDecodeStream');
     }
 
-    function it_is_a_stream()
-    {
-        $this->shouldImplement('Psr\Http\Message\StreamInterface');
-    }
-
     function it_reads()
     {
         // "This is a test stream" | deflate

spec/Encoding/GzipEncodeStreamSpec.php

@@ -8,6 +8,8 @@
 
 class GzipEncodeStreamSpec extends ObjectBehavior
 {
+    use StreamBehavior, ZlibStreamBehavior;
+
     function let(StreamInterface $stream)
     {
         if (defined('HHVM_VERSION')) {
@@ -22,11 +24,6 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Message\Encoding\GzipEncodeStream');
     }
 
-    function it_is_a_stream()
-    {
-        $this->shouldImplement('Psr\Http\Message\StreamInterface');
-    }
-
     function it_reads()
     {
         $stream = new MemoryStream('This is a test stream');

spec/Encoding/InflateStreamSpec.php

@@ -7,6 +7,8 @@
 
 class InflateStreamSpec extends ObjectBehavior
 {
+    use StreamBehavior, ZlibStreamBehavior;
+
     function let(StreamInterface $stream)
     {
         $this->beConstructedWith($stream);
@@ -17,11 +19,6 @@ function it_is_initializable()
         $this->shouldHaveType('Http\Message\Encoding\InflateStream');
     }
 
-    function it_is_a_stream()
-    {
-        $this->shouldImplement('Psr\Http\Message\StreamInterface');
-    }
-
     function it_reads()
     {
         // "This is a test stream" | deflate

spec/Encoding/StreamBehavior.php

@@ -0,0 +1,11 @@
+<?php
+
+namespace spec\Http\Message\Encoding;
+
+trait StreamBehavior
+{
+    function it_is_a_stream()
+    {
+        $this->shouldImplement('Psr\Http\Message\StreamInterface');
+    }
+}

spec/Encoding/ZlibStreamBehavior.php

@@ -0,0 +1,51 @@
+<?php
+
+namespace spec\Http\Message\Encoding {
+
+    use Psr\Http\Message\StreamInterface;
+    use PhpSpec\Exception\Example\SkippingException;
+
+    trait ZlibStreamBehavior
+    {
+        function it_throws_an_exception_when_zlib_is_not_enabled()
+        {
+            ZlibExtensionLoadedMock::$enabled = true;
+
+            $this->shouldThrow('RuntimeException')->duringInstantiation();
+
+            ZlibExtensionLoadedMock::$enabled = false;
+        }
+    }
+
+    class ZlibExtensionLoadedMock
+    {
+        /**
+         * If enabled, the mocked method is used.
+         *
+         * @var bool
+         */
+        public static $enabled = false;
+
+        /**
+         * extension_loaded function mock.
+         */
+        public static function extensionLoaded()
+        {
+            if (static::$enabled) {
+                return false;
+            } else {
+                return call_user_func_array('\extension_loaded', func_get_args());
+            }
+        }
+    }
+}
+
+namespace Http\Message\Encoding {
+
+    use spec\Http\Message\Encoding\ZlibExtensionLoadedMock;
+
+    function extension_loaded($extension)
+    {
+        return ZlibExtensionLoadedMock::extensionLoaded($extension);
+    }
+}

src/Encoding/CompressStream.php

@@ -13,6 +13,10 @@ class CompressStream extends FilteredStream
 {
     public function __construct(StreamInterface $stream, $level = -1)
     {
+        if (!extension_loaded('zlib')) {
+            throw new \RuntimeException('The zlib extension must be enabled to use this stream');
+        }
+
         parent::__construct($stream, ['window' => 15, 'level' => $level], ['window' => 15]);
     }
 

src/Encoding/DecompressStream.php

@@ -13,6 +13,10 @@ class DecompressStream extends FilteredStream
 {
     public function __construct(StreamInterface $stream, $level = -1)
     {
+        if (!extension_loaded('zlib')) {
+            throw new \RuntimeException('The zlib extension must be enabled to use this stream');
+        }
+
         parent::__construct($stream, ['window' => 15], ['window' => 15, 'level' => $level]);
     }
 

src/Encoding/GzipDecodeStream.php

@@ -13,6 +13,10 @@ class GzipDecodeStream extends FilteredStream
 {
     public function __construct(StreamInterface $stream, $level = -1)
     {
+        if (!extension_loaded('zlib')) {
+            throw new \RuntimeException('The zlib extension must be enabled to use this stream');
+        }
+
         parent::__construct($stream, ['window' => 31], ['window' => 31, 'level' => $level]);
     }
 

src/Encoding/GzipEncodeStream.php

@@ -13,6 +13,10 @@ class GzipEncodeStream extends FilteredStream
 {
     public function __construct(StreamInterface $stream, $level = -1)
     {
+        if (!extension_loaded('zlib')) {
+            throw new \RuntimeException('The zlib extension must be enabled to use this stream');
+        }
+
         parent::__construct($stream, ['window' => 31, 'level' => $level], ['window' => 31]);
     }
 

src/Encoding/InflateStream.php

@@ -13,6 +13,10 @@ class InflateStream extends FilteredStream
 {
     public function __construct(StreamInterface $stream, $level = -1)
     {
+        if (!extension_loaded('zlib')) {
+            throw new \RuntimeException('The zlib extension must be enabled to use this stream');
+        }
+
         parent::__construct($stream, ['window' => -15], ['window' => -15, 'level' => $level]);
     }