Skip to content

Commit 7f7dd42

Browse files
committed
Skip specific tests on HHVM instead of allowing to fail, see #6
1 parent c7fcd53 commit 7f7dd42

File tree

7 files changed

+30
-2
lines changed

7 files changed

+30
-2
lines changed

.travis.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ branches:
2222
- /^analysis-.*$/
2323

2424
matrix:
25-
allow_failures:
26-
- php: hhvm
2725
fast_finish: true
2826
include:
2927
- php: 5.4

spec/Encoding/ChunkStreamSpec.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,17 @@
33
namespace spec\Http\Message\Encoding;
44

55
use Psr\Http\Message\StreamInterface;
6+
use PhpSpec\Exception\Example\SkippingException;
67
use PhpSpec\ObjectBehavior;
78

89
class ChunkStreamSpec extends ObjectBehavior
910
{
1011
function let(StreamInterface $stream)
1112
{
13+
if (defined('HHVM_VERSION')) {
14+
throw new SkippingException('Skipping test as there is no dechunk filter on hhvm');
15+
}
16+
1217
$this->beConstructedWith($stream);
1318
}
1419

spec/Encoding/CompressStreamSpec.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,17 @@
33
namespace spec\Http\Message\Encoding;
44

55
use Psr\Http\Message\StreamInterface;
6+
use PhpSpec\Exception\Example\SkippingException;
67
use PhpSpec\ObjectBehavior;
78

89
class CompressStreamSpec extends ObjectBehavior
910
{
1011
function let(StreamInterface $stream)
1112
{
13+
if (defined('HHVM_VERSION')) {
14+
throw new SkippingException('Skipping test as zlib is not working on hhvm');
15+
}
16+
1217
$this->beConstructedWith($stream);
1318
}
1419

spec/Encoding/DechunkStreamSpec.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,17 @@
33
namespace spec\Http\Message\Encoding;
44

55
use Psr\Http\Message\StreamInterface;
6+
use PhpSpec\Exception\Example\SkippingException;
67
use PhpSpec\ObjectBehavior;
78

89
class DechunkStreamSpec extends ObjectBehavior
910
{
1011
function let(StreamInterface $stream)
1112
{
13+
if (defined('HHVM_VERSION')) {
14+
throw new SkippingException('Skipping test as there is no dechunk filter on hhvm');
15+
}
16+
1217
$this->beConstructedWith($stream);
1318
}
1419

spec/Encoding/DecompressStreamSpec.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,17 @@
33
namespace spec\Http\Message\Encoding;
44

55
use Psr\Http\Message\StreamInterface;
6+
use PhpSpec\Exception\Example\SkippingException;
67
use PhpSpec\ObjectBehavior;
78

89
class DecompressStreamSpec extends ObjectBehavior
910
{
1011
function let(StreamInterface $stream)
1112
{
13+
if (defined('HHVM_VERSION')) {
14+
throw new SkippingException('Skipping test as zlib is not working on hhvm');
15+
}
16+
1217
$this->beConstructedWith($stream);
1318
}
1419

spec/Encoding/GzipDecodeStreamSpec.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,17 @@
33
namespace spec\Http\Message\Encoding;
44

55
use Psr\Http\Message\StreamInterface;
6+
use PhpSpec\Exception\Example\SkippingException;
67
use PhpSpec\ObjectBehavior;
78

89
class GzipDecodeStreamSpec extends ObjectBehavior
910
{
1011
function let(StreamInterface $stream)
1112
{
13+
if (defined('HHVM_VERSION')) {
14+
throw new SkippingException('Skipping test as zlib is not working on hhvm');
15+
}
16+
1217
$this->beConstructedWith($stream);
1318
}
1419

spec/Encoding/GzipEncodeStreamSpec.php

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -3,12 +3,17 @@
33
namespace spec\Http\Message\Encoding;
44

55
use Psr\Http\Message\StreamInterface;
6+
use PhpSpec\Exception\Example\SkippingException;
67
use PhpSpec\ObjectBehavior;
78

89
class GzipEncodeStreamSpec extends ObjectBehavior
910
{
1011
function let(StreamInterface $stream)
1112
{
13+
if (defined('HHVM_VERSION')) {
14+
throw new SkippingException('Skipping test as zlib is not working on hhvm');
15+
}
16+
1217
$this->beConstructedWith($stream);
1318
}
1419

0 commit comments

Comments
 (0)