From a9551c5d3ddb5cfffa76da0a5a9758b0d20b79fb Mon Sep 17 00:00:00 2001 From: David Buchmann Date: Tue, 5 Feb 2019 13:49:07 +0100 Subject: [PATCH] explain in phpdoc that guzzle instance must not throw exceptions --- src/Client.php | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/Client.php b/src/Client.php index b90fcd3..37cb21d 100644 --- a/src/Client.php +++ b/src/Client.php @@ -25,6 +25,11 @@ final class Client implements HttpClient, HttpAsyncClient */ private $client; + /** + * If you pass a Guzzle instance as $client, make sure to configure Guzzle to not + * throw exceptions on HTTP error status codes, or this adapter will violate PSR-18. + * See also self::buildClient at the bottom of this class. + */ public function __construct(?ClientInterface $client = null) { if (!$client) {