From 3bf6949b1b12fb4e6b13164688c42b7337a72c91 Mon Sep 17 00:00:00 2001 From: Tobias Nyholm Date: Thu, 28 Jul 2016 20:00:07 +0200 Subject: [PATCH 1/5] Added a note about no body for GET requests --- clients/buzz-adapter.rst | 8 ++++++++ spelling_word_list.txt | 1 + 2 files changed, 9 insertions(+) diff --git a/clients/buzz-adapter.rst b/clients/buzz-adapter.rst index 9a86878..1e04e66 100644 --- a/clients/buzz-adapter.rst +++ b/clients/buzz-adapter.rst @@ -3,6 +3,7 @@ Buzz Adapter An HTTPlug adapter for the `Buzz HTTP client`_. + Installation ------------ @@ -54,6 +55,13 @@ Or if you installed the :doc:`discovery ` layer:: The message factory parameter is mandatory if the discovery layer is not installed. +Be aware +-------- + +This adapter violates the Liskov substitution principle in a rare edge case. When the adapter is configured to use +Buzz' Curl client, it does not send request bodies for request methods such as GET, HEAD and TRACE. A RequestException +will be thrown if this ever happens. + .. include:: includes/further-reading-sync.inc .. _Buzz HTTP client: https://github.com/kriswallsmith/Buzz diff --git a/spelling_word_list.txt b/spelling_word_list.txt index 21f86fe..08725a2 100644 --- a/spelling_word_list.txt +++ b/spelling_word_list.txt @@ -8,6 +8,7 @@ Diactoros fallback GitHub hotfix +Liskov Symfony HTTPlug Ivory From 6a8e15d19dc013023ebb8e7c57ad887e437a89fa Mon Sep 17 00:00:00 2001 From: Tobias Nyholm Date: Thu, 28 Jul 2016 20:01:21 +0200 Subject: [PATCH 2/5] Removed extra line --- clients/buzz-adapter.rst | 1 - 1 file changed, 1 deletion(-) diff --git a/clients/buzz-adapter.rst b/clients/buzz-adapter.rst index 1e04e66..606eb5f 100644 --- a/clients/buzz-adapter.rst +++ b/clients/buzz-adapter.rst @@ -3,7 +3,6 @@ Buzz Adapter An HTTPlug adapter for the `Buzz HTTP client`_. - Installation ------------ From d82d018e937362d7aab395fcb46de4274ae24dc1 Mon Sep 17 00:00:00 2001 From: Tobias Nyholm Date: Tue, 2 Aug 2016 14:39:30 +0200 Subject: [PATCH 3/5] Fixed typo --- clients/buzz-adapter.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/clients/buzz-adapter.rst b/clients/buzz-adapter.rst index 606eb5f..7b5a16d 100644 --- a/clients/buzz-adapter.rst +++ b/clients/buzz-adapter.rst @@ -58,9 +58,11 @@ Be aware -------- This adapter violates the Liskov substitution principle in a rare edge case. When the adapter is configured to use -Buzz' Curl client, it does not send request bodies for request methods such as GET, HEAD and TRACE. A RequestException +Buzz' Curl client, it does not send request bodies for request methods such as GET, HEAD and TRACE. A ``RequestException`` will be thrown if this ever happens. +If you need GET request with a body (e.g. for Elasticsearch) you need to use a different client like Guzzle 6. + .. include:: includes/further-reading-sync.inc .. _Buzz HTTP client: https://github.com/kriswallsmith/Buzz From 3ab3334c65ef686ed75f72395f789eda93ab5672 Mon Sep 17 00:00:00 2001 From: Tobias Nyholm Date: Tue, 2 Aug 2016 17:52:09 +0200 Subject: [PATCH 4/5] Update buzz-adapter.rst --- clients/buzz-adapter.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clients/buzz-adapter.rst b/clients/buzz-adapter.rst index 7b5a16d..f241dfa 100644 --- a/clients/buzz-adapter.rst +++ b/clients/buzz-adapter.rst @@ -61,7 +61,7 @@ This adapter violates the Liskov substitution principle in a rare edge case. Whe Buzz' Curl client, it does not send request bodies for request methods such as GET, HEAD and TRACE. A ``RequestException`` will be thrown if this ever happens. -If you need GET request with a body (e.g. for Elasticsearch) you need to use a different client like Guzzle 6. +If you need GET request with a body (e.g. for Elasticsearch) you need to use the Buzz FileGetContents client or choose a different HTTPlug client like Guzzle 6. .. include:: includes/further-reading-sync.inc From 1d198ad46e08491bd68e89a67877c8d28505913c Mon Sep 17 00:00:00 2001 From: Tobias Nyholm Date: Tue, 2 Aug 2016 17:52:46 +0200 Subject: [PATCH 5/5] Update spelling_word_list.txt --- spelling_word_list.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/spelling_word_list.txt b/spelling_word_list.txt index 08725a2..851b255 100644 --- a/spelling_word_list.txt +++ b/spelling_word_list.txt @@ -5,6 +5,7 @@ boolean callables cURL Diactoros +Elasticsearch fallback GitHub hotfix