Skip to content

Commit da5eb18

Browse files
committed
get rid of more dangerous ssl settings in examples. #217
1 parent 4150a00 commit da5eb18

File tree

4 files changed

+2
-6
lines changed

4 files changed

+2
-6
lines changed

clients/curl-client.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@ You can use `cURL options <http://php.net/curl_setopt>`_ to configure Client::
4848

4949
$options = [
5050
CURLOPT_CONNECTTIMEOUT => 10, // The number of seconds to wait while trying to connect.
51-
CURLOPT_SSL_VERIFYPEER => false // Stop cURL from verifying the peer's certificate
5251
];
5352
$client = new Client(MessageFactoryDiscovery::find(), StreamFactoryDiscovery::find(), $options);
5453

clients/guzzle6-adapter.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,6 @@ to the client::
2222
use Http\Adapter\Guzzle6\Client as GuzzleAdapter;
2323

2424
$config = [
25-
'verify' => false,
2625
'timeout' => 2,
2726
'handler' => //...
2827
// ...
@@ -37,7 +36,7 @@ to the client::
3736
use GuzzleHttp\Client as GuzzleClient;
3837
use Http\Adapter\Guzzle6\Client as GuzzleAdapter;
3938

40-
$config = ['verify' => false ];
39+
$config = ['timeout' => 5];
4140
// ...
4241
$guzzle = new GuzzleClient($config);
4342
// ...

integrations/symfony-bundle.rst

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,6 @@ Usage
6161
factory: 'httplug.factory.guzzle6'
6262
plugins: ['httplug.plugin.logger']
6363
config:
64-
verify: false
6564
timeout: 2
6665
6766
.. code-block:: php
@@ -177,7 +176,7 @@ services.
177176
config:
178177
# These options are given to Guzzle without validation.
179178
defaults:
180-
verify_ssl: false
179+
# timeout if connection is not established after 4 seconds
181180
timeout: 4
182181
acme:
183182
factory: 'httplug.factory.curl'

integrations/symfony-full-configuration.rst

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,6 @@ This page shows an example of all configuration values provided by the bundle.
7575
http_methods_client: false # Can only be true if flexible_client is false
7676
config:
7777
# Options to the Guzzle 6 constructor
78-
verify: false
7978
timeout: 2
8079
plugins:
8180
# Can reference a globally configured plugin service

0 commit comments

Comments
 (0)