Skip to content

Commit dd33789

Browse files
committed
symfony httplug adapter needs php-http httplug to be installed
if we don't check for the httplug client interface, we trigger a warning: https://github.com/symfony/http-client/blob/290eb481973b4984eb59377585f6afbc65a0f645/HttplugClient.php#L44
1 parent de90ab2 commit dd33789

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/Psr18ClientDiscovery.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ public static function find()
2424
try {
2525
$client = static::findOneByType(ClientInterface::class);
2626
} catch (DiscoveryFailedException $e) {
27-
throw new \Http\Discovery\Exception\NotFoundException('No PSR-18 clients found. Make sure to install a package providing "psr/http-client-implementation". Example: "php-http/guzzle6-adapter".', 0, $e);
27+
throw new \Http\Discovery\Exception\NotFoundException('No PSR-18 clients found. Make sure to install a package providing "psr/http-client-implementation". Example: "php-http/guzzle7-adapter".', 0, $e);
2828
}
2929

3030
return static::instantiateClass($client);

src/Strategy/CommonClassesStrategy.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -75,14 +75,14 @@ final class CommonClassesStrategy implements DiscoveryStrategy
7575
['class' => SlimUriFactory::class, 'condition' => [SlimRequest::class, SlimUriFactory::class]],
7676
],
7777
HttpAsyncClient::class => [
78-
['class' => SymfonyHttplug::class, 'condition' => [SymfonyHttplug::class, Promise::class, RequestFactory::class, [self::class, 'isPsr17FactoryInstalled']]],
78+
['class' => SymfonyHttplug::class, 'condition' => [SymfonyHttplug::class, HttpClient::class, Promise::class, RequestFactory::class, [self::class, 'isPsr17FactoryInstalled']]],
7979
['class' => Guzzle7::class, 'condition' => Guzzle7::class],
8080
['class' => Guzzle6::class, 'condition' => Guzzle6::class],
8181
['class' => Curl::class, 'condition' => Curl::class],
8282
['class' => React::class, 'condition' => React::class],
8383
],
8484
HttpClient::class => [
85-
['class' => SymfonyHttplug::class, 'condition' => [SymfonyHttplug::class, RequestFactory::class, [self::class, 'isPsr17FactoryInstalled']]],
85+
['class' => SymfonyHttplug::class, 'condition' => [SymfonyHttplug::class, HttpClient::class, RequestFactory::class, [self::class, 'isPsr17FactoryInstalled']]],
8686
['class' => Guzzle7::class, 'condition' => Guzzle7::class],
8787
['class' => Guzzle6::class, 'condition' => Guzzle6::class],
8888
['class' => Guzzle5::class, 'condition' => Guzzle5::class],

0 commit comments

Comments
 (0)