From 81974a8c64bbbdcde51eec45c5e43e07805ea7ec Mon Sep 17 00:00:00 2001 From: Fabien Bourigault Date: Mon, 10 Jul 2017 22:24:32 +0200 Subject: [PATCH] do not pass client_name option to PluginClient constructor --- spec/PluginClientFactorySpec.php | 5 +++++ src/PluginClientFactory.php | 2 ++ 2 files changed, 7 insertions(+) diff --git a/spec/PluginClientFactorySpec.php b/spec/PluginClientFactorySpec.php index da9febe..1f8d9e8 100644 --- a/spec/PluginClientFactorySpec.php +++ b/spec/PluginClientFactorySpec.php @@ -18,4 +18,9 @@ function it_returns_a_plugin_client(HttpClient $httpClient) $client->shouldHaveType('Http\Client\Common\PluginClient'); } + + function it_does_not_construct_plugin_client_with_client_name_option(HttpClient $httpClient) + { + $this->createClient($httpClient, [], ['client_name' => 'Default']); + } } diff --git a/src/PluginClientFactory.php b/src/PluginClientFactory.php index 13a4ba7..bd4c08f 100644 --- a/src/PluginClientFactory.php +++ b/src/PluginClientFactory.php @@ -55,6 +55,8 @@ public function createClient($client, array $plugins = [], array $options = []) return $factory($client, $plugins, $options); } + unset($options['client_name']); + return new PluginClient($client, $plugins, $options); } }