Implemented Feedback

Till Hildebrandt · Till Hildebrandt · commit 61aab950a803 · 2019-11-26T10:24:54.000+01:00
- removed unnecessary string concatenation
 - set isCacheableRequest to private
diff --git a/src/CachePlugin.php b/src/CachePlugin.php
@@ -73,7 +73,7 @@ public function __construct(CacheItemPoolInterface $pool, StreamFactory $streamF
         $this->streamFactory = $streamFactory;
 
         if (isset($config['respect_cache_headers']) && isset($config['respect_response_cache_directives'])) {
-            throw new \InvalidArgumentException('You can\'t provide config option "respect_cache_headers" and "respect_response_cache_directives". '.'Use "respect_response_cache_directives" instead.');
+            throw new \InvalidArgumentException('You can\'t provide config option "respect_cache_headers" and "respect_response_cache_directives". Use "respect_response_cache_directives" instead.');
         }
 
         $optionsResolver = new OptionsResolver();
@@ -271,7 +271,7 @@ protected function isCacheable(ResponseInterface $response)
      *
      * @return bool
      */
-    protected function isCacheableRequest(RequestInterface $request)
+    private function isCacheableRequest(RequestInterface $request)
     {
         foreach ($this->config['blacklisted_paths'] as $not_to_cache_path) {
             if (1 === preg_match('/'.$not_to_cache_path.'/', $request->getUri())) {

Original file line number	Diff line number	Diff line change
`@@ -73,7 +73,7 @@ public function __construct(CacheItemPoolInterface $pool, StreamFactory $streamF`
`73`	`73`	`$this->streamFactory = $streamFactory;`
`74`	`74`
`75`	`75`	`if (isset($config['respect_cache_headers']) && isset($config['respect_response_cache_directives'])) {`
`76`		`- throw new \InvalidArgumentException('You can\'t provide config option "respect_cache_headers" and "respect_response_cache_directives". '.'Use "respect_response_cache_directives" instead.');`
	`76`	`+ throw new \InvalidArgumentException('You can\'t provide config option "respect_cache_headers" and "respect_response_cache_directives". Use "respect_response_cache_directives" instead.');`
`77`	`77`	`}`
`78`	`78`
`79`	`79`	`$optionsResolver = new OptionsResolver();`
`@@ -271,7 +271,7 @@ protected function isCacheable(ResponseInterface $response)`
`271`	`271`	`*`
`272`	`272`	`* @return bool`
`273`	`273`	`*/`
`274`		`- protected function isCacheableRequest(RequestInterface $request)`
	`274`	`+ private function isCacheableRequest(RequestInterface $request)`
`275`	`275`	`{`
`276`	`276`	`foreach ($this->config['blacklisted_paths'] as $not_to_cache_path) {`
`277`	`277`	`if (1 === preg_match('/'.$not_to_cache_path.'/', $request->getUri())) {`