From 4f8bd89ab736c31c36d8e8041f161ce0e6f5860a Mon Sep 17 00:00:00 2001
From: Ruud Kamphuis <ruudk@users.noreply.github.com>
Date: Mon, 19 Nov 2018 20:30:11 +0100
Subject: [PATCH] Make underlying http client also public when configured

For example: when configuring an `acme` client that is public, it should make `httplug.client.acme.client` also public.
---
 CHANGELOG.md                             | 6 ++++++
 DependencyInjection/HttplugExtension.php | 4 ++--
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/CHANGELOG.md b/CHANGELOG.md
index 37d31b74..95f681a3 100644
--- a/CHANGELOG.md
+++ b/CHANGELOG.md
@@ -2,6 +2,12 @@
 
 The change log describes what is "Added", "Removed", "Changed" or "Fixed" between each release.
 
+## Unreleased
+
+### Added
+
+- Make underlying http client (`httplug.client.acme.client`) also public when configured
+
 ## 1.13.0 - 2018-11-13
 
 ### Added
diff --git a/DependencyInjection/HttplugExtension.php b/DependencyInjection/HttplugExtension.php
index c88e2849..5f7acd6d 100644
--- a/DependencyInjection/HttplugExtension.php
+++ b/DependencyInjection/HttplugExtension.php
@@ -322,10 +322,10 @@ private function configureClient(ContainerBuilder $container, $clientName, array
                 ->register($serviceId.'.client', HttpClient::class)
                 ->setFactory([new Reference($arguments['factory']), 'createClient'])
                 ->addArgument($arguments['config'])
-                ->setPublic(false);
+                ->setPublic($arguments['public'] ? true : false);
         } else {
             $container
-                ->setAlias($serviceId.'.client', new Alias($arguments['service'], false));
+                ->setAlias($serviceId.'.client', new Alias($arguments['service'], $arguments['public'] ? true : false));
         }
 
         $definition = $container