Pull-Request-Feedback

 - removed duplicated cache_listeners node from src/DependencyInjection/Configuration.php
 - TESTS: added multiple cache_listeners

Author: Till Hildebrandt

src/DependencyInjection/Configuration.php

@@ -751,10 +751,6 @@ private function createCachePluginNode()
                         ->end()
                     ->end()
                 ->end()
-                ->arrayNode('cache_listeners')
-                    ->info('A list of service ids to act on the response based on the results of the cache check. Must implement '.CacheListener::class.'. Defaults to an empty array.')
-                    ->beforeNormalization()->ifNull()->thenEmptyArray()->castToArray()->ifEmpty()->thenUnset()->end()
-                ->end()
                 ->enumNode('hash_algo')
                     ->info('Hashing algorithm to use')
                     ->values(hash_algos())

tests/Resources/Fixtures/config/full.php

@@ -110,7 +110,10 @@
                 'cache_key_generator' => null,
                 'respect_response_cache_directives' => ['X-Foo'],
                 'blacklisted_paths' => ['@/path/not-to-be/cached@'],
-                'cache_listeners' => [],
+                'cache_listeners' => [
+                    'my_cache_listener_0',
+                    'my_cache_listener_1',
+                ],
             ],
         ],
         'cookie' => [

tests/Resources/Fixtures/config/full.xml

@@ -62,7 +62,8 @@
             </authentication>
             <cache cache-pool="my_cache_pool" stream-factory="my_other_stream_factory">
                 <config default-ttl="42" cache-lifetime="2592000" hash-algo="sha1" cache-key-generator="null">
-                    <cache-listeners></cache-listeners>
+                    <cache-listeners>my_cache_listener_0</cache-listeners>
+                    <cache-listeners>my_cache_listener_1</cache-listeners>
                     <respect-response-cache-directive>X-Foo</respect-response-cache-directive>
                     <method>GET</method>
                     <blacklisted-paths>@/path/not-to-be/cached@</blacklisted-paths>

tests/Resources/Fixtures/config/full.yml

@@ -82,7 +82,9 @@ httplug:
                   - X-Foo
                 blacklisted_paths:
                   - '@/path/not-to-be/cached@'
-                cache_listeners: []
+                cache_listeners:
+                  - my_cache_listener_0
+                  - my_cache_listener_1
         cookie:
             cookie_jar: my_cookie_jar
         decoder:

tests/Unit/DependencyInjection/ConfigurationTest.php

@@ -267,7 +267,10 @@ public function testSupportsAllConfigFormats(): void
                         'cache_key_generator' => null,
                         'respect_response_cache_directives' => ['X-Foo'],
                         'blacklisted_paths' => ['@/path/not-to-be/cached@'],
-                        'cache_listeners' => [],
+                        'cache_listeners' => [
+                            'my_cache_listener_0',
+                            'my_cache_listener_1'
+                        ],
                     ],
                 ],
                 'cookie' => [